Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: chrome/browser/chromeos/login/user_image_manager_browsertest.cc

Issue 13088002: Use only IJG decoding path to decode profile pictures on login screen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/user_image_manager_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/memory/ref_counted_memory.h" 9 #include "base/memory/ref_counted_memory.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 ScopedMockUserManagerEnabler mock_user_manager; 225 ScopedMockUserManagerEnabler mock_user_manager;
226 SaveUserImagePNG( 226 SaveUserImagePNG(
227 kTestUser1, kDefaultImageResourceIDs[kFirstDefaultImageIndex]); 227 kTestUser1, kDefaultImageResourceIDs[kFirstDefaultImageIndex]);
228 } 228 }
229 229
230 IN_PROC_BROWSER_TEST_F(UserImageManagerTest, PRE_NonJPEGImageFromFile) { 230 IN_PROC_BROWSER_TEST_F(UserImageManagerTest, PRE_NonJPEGImageFromFile) {
231 UserManager::Get()->GetUsers(); // Load users. 231 UserManager::Get()->GetUsers(); // Load users.
232 // Old info preserved. 232 // Old info preserved.
233 ExpectOldUserImageInfo(kTestUser1, User::kExternalImageIndex, 233 ExpectOldUserImageInfo(kTestUser1, User::kExternalImageIndex,
234 GetUserImagePath(kTestUser1, "png")); 234 GetUserImagePath(kTestUser1, "png"));
235 const User* user = UserManager::Get()->FindUser(kTestUser1);
236 EXPECT_TRUE(user->image_is_stub());
235 LogIn(kTestUser1); 237 LogIn(kTestUser1);
236 // Wait for migration. 238 // Wait for migration.
237 content::RunMessageLoop(); 239 content::RunMessageLoop();
238 // Image info is migrated and the image is converted to JPG. 240 // Image info is migrated and the image is converted to JPG.
239 ExpectNewUserImageInfo(kTestUser1, User::kExternalImageIndex, 241 ExpectNewUserImageInfo(kTestUser1, User::kExternalImageIndex,
240 GetUserImagePath(kTestUser1, "jpg")); 242 GetUserImagePath(kTestUser1, "jpg"));
241 const User* user = UserManager::Get()->GetLoggedInUser(); 243 user = UserManager::Get()->GetLoggedInUser();
242 ASSERT_TRUE(user); 244 ASSERT_TRUE(user);
243 EXPECT_FALSE(user->image_is_safe_format()); 245 EXPECT_FALSE(user->image_is_safe_format());
244 // Check image dimensions. 246 // Check image dimensions.
245 const gfx::ImageSkia& saved_image = GetDefaultImage(kFirstDefaultImageIndex); 247 const gfx::ImageSkia& saved_image = GetDefaultImage(kFirstDefaultImageIndex);
246 EXPECT_EQ(saved_image.width(), user->image().width()); 248 EXPECT_EQ(saved_image.width(), user->image().width());
247 EXPECT_EQ(saved_image.height(), user->image().height()); 249 EXPECT_EQ(saved_image.height(), user->image().height());
248 } 250 }
249 251
250 IN_PROC_BROWSER_TEST_F(UserImageManagerTest, NonJPEGImageFromFile) { 252 IN_PROC_BROWSER_TEST_F(UserImageManagerTest, NonJPEGImageFromFile) {
251 ExpectImageChange(); 253 ExpectImageChange();
252 UserManager::Get()->GetUsers(); // Load users. 254 UserManager::Get()->GetUsers(); // Load users.
253 // Wait for image load. 255 // Wait for image load.
254 content::RunMessageLoop(); 256 content::RunMessageLoop();
255 // Now the migrated image is used. 257 // Now the migrated image is used.
256 const User* user = UserManager::Get()->FindUser(kTestUser1); 258 const User* user = UserManager::Get()->FindUser(kTestUser1);
257 ASSERT_TRUE(user); 259 ASSERT_TRUE(user);
258 EXPECT_TRUE(user->image_is_safe_format()); 260 EXPECT_TRUE(user->image_is_safe_format());
259 // Check image dimensions. Images can't be compared since JPEG is lossy. 261 // Check image dimensions. Images can't be compared since JPEG is lossy.
260 const gfx::ImageSkia& saved_image = GetDefaultImage(kFirstDefaultImageIndex); 262 const gfx::ImageSkia& saved_image = GetDefaultImage(kFirstDefaultImageIndex);
261 EXPECT_EQ(saved_image.width(), user->image().width()); 263 EXPECT_EQ(saved_image.width(), user->image().width());
262 EXPECT_EQ(saved_image.height(), user->image().height()); 264 EXPECT_EQ(saved_image.height(), user->image().height());
263 } 265 }
264 266
265 } // namespace chromeos 267 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/user_image_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698