Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2404)

Unified Diff: appengine/swarming/swarming_bot/os_utilities_test.py

Issue 1308543003: Remove stale android code and remove stand alone functionality. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/swarming_bot/os_utilities.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/swarming_bot/os_utilities_test.py
diff --git a/appengine/swarming/swarming_bot/os_utilities_test.py b/appengine/swarming/swarming_bot/os_utilities_test.py
index e3061bc6f8323f417259f024a07fee10ba17607c..5ede019db81f9a39d99e2b1188c54aa9c3791c92 100755
--- a/appengine/swarming/swarming_bot/os_utilities_test.py
+++ b/appengine/swarming/swarming_bot/os_utilities_test.py
@@ -129,68 +129,6 @@ class TestOsUtilities(auto_stub.TestCase):
expected.add(u'integrity')
self.assertEqual(expected, set(actual))
- def test_get_adb_list_devices(self):
- stdout = (
- '* daemon not running. starting it now on port 5037 *\n'
- '* daemon started successfully *\n'
- 'List of devices attached\n'
- 'A12B304C5DE device\n'
- 'emulator-1234 device\n'
- '\n')
- self.mock(subprocess, 'check_output', lambda *_: stdout)
- actual = os_utilities.get_adb_list_devices()
- self.assertEqual(['A12B304C5DE', 'emulator-1234'], actual)
-
- def test_get_adb_device_properties_raw(self):
- stdout = (
- '# begin build properties\n'
- '# autogenerated by buildinfo.sh\n'
- 'ro.build.id=KRT16S\n'
- 'ro.build.display.id=KRT16S\n'
- 'ro.build.version.incremental=920375\n'
- '\n')
- self.mock(subprocess, 'check_output', lambda *_: stdout)
- actual = os_utilities.get_adb_device_properties_raw('123')
- expected = {
- u'ro.build.display.id': u'KRT16S',
- u'ro.build.id': u'KRT16S',
- u'ro.build.version.incremental': u'920375',
- }
- self.assertEqual(expected, actual)
-
- def test_get_dimensions_android(self):
- props = dict((k, k) for k in os_utilities.ANDROID_DETAILS)
- props[u'bar'] = u'foo'
- self.mock(os_utilities, 'get_adb_device_properties_raw', lambda *_: props)
- actual = os_utilities.get_dimensions_android('123')
- expected = {
- u'id': [u'123'],
- u'ro.board.platform': [u'ro.board.platform'],
- u'ro.build.id': [u'ro.build.id'],
- u'ro.build.tags': [u'ro.build.tags'],
- u'ro.build.type': [u'ro.build.type'],
- u'ro.build.version.sdk': [u'ro.build.version.sdk'],
- u'ro.product.board': [u'ro.product.board'],
- u'ro.product.cpu.abi': [u'ro.product.cpu.abi'],
- u'ro.product.cpu.abi2': [u'ro.product.cpu.abi2'],
- }
- self.assertEqual(expected, actual)
-
- def test_get_state_android(self):
- self.mock(time, 'time', lambda: os_utilities._STARTED_TS + 1)
- expected_dimensions = dict((k, k) for k in os_utilities.ANDROID_DETAILS)
- props = expected_dimensions.copy()
- props[u'bar'] = u'foo'
- self.mock(os_utilities, 'get_adb_device_properties_raw', lambda *_: props)
-
- expected_dimensions[u'id'] = [u'123']
- actual = os_utilities.get_state_android('123')
- expected = {
- u'device': {},
- u'host': os_utilities.get_state(),
- }
- self.assertEqual(expected, actual)
-
def test_setup_auto_startup_win(self):
# TODO(maruel): Figure out a way to test properly.
pass
« no previous file with comments | « appengine/swarming/swarming_bot/os_utilities.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698