Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4281)

Unified Diff: chrome/browser/manifest/manifest_icon_selector.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Fix test failure Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/manifest/manifest_icon_selector.h
diff --git a/chrome/browser/manifest/manifest_icon_selector.h b/chrome/browser/manifest/manifest_icon_selector.h
index 54ccdbab988fd72e21a94d9362f03531d3a2e28f..a2b5c24d5d8963a79410cfccaf569da4ec76151f 100644
--- a/chrome/browser/manifest/manifest_icon_selector.h
+++ b/chrome/browser/manifest/manifest_icon_selector.h
@@ -33,13 +33,14 @@ class ManifestIconSelector {
// If/when this class is generalized, it may be a good idea to switch this to
// taking in pixels, instead.
//
- // The icon returned will have a minimum size of an image one density bucket
- // smaller than the device denisity * preferred_icon_size_in_dp.
+ // Any icon returned will be close as possible to |ideal_icon_size_in_dp|
+ // with a size not less than |minimum_icon_size_in_dp|.
//
// Returns the icon url if a suitable icon is found. An empty URL otherwise.
static GURL FindBestMatchingIcon(
const std::vector<content::Manifest::Icon>& icons,
int ideal_icon_size_in_dp,
+ int minimum_icon_size_in_dp,
const gfx::Screen* screen);
private:
« no previous file with comments | « chrome/browser/manifest/manifest_icon_downloader.cc ('k') | chrome/browser/manifest/manifest_icon_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698