Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: chrome/browser/banners/app_banner_manager_desktop.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Fix test failure Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager_desktop.cc
diff --git a/chrome/browser/banners/app_banner_manager_desktop.cc b/chrome/browser/banners/app_banner_manager_desktop.cc
index 09d7fdf88f27a7dcc3338930cc277e878871fcd7..996696bb47fda177049bbf4796ffdfcc1834147d 100644
--- a/chrome/browser/banners/app_banner_manager_desktop.cc
+++ b/chrome/browser/banners/app_banner_manager_desktop.cc
@@ -10,7 +10,7 @@
#include "extensions/common/constants.h"
namespace {
-// TODO(dominickn) Enforce the set of icons which will guarantee the best
+// TODO(dominickn) Identify the best minimum icon size to guarantee the best
// user experience.
int kMinimumIconSize = extension_misc::EXTENSION_ICON_LARGE;
} // anonymous namespace
@@ -25,15 +25,15 @@ bool AppBannerManagerDesktop::IsEnabled() {
}
AppBannerDataFetcher* AppBannerManagerDesktop::CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
- const int ideal_icon_size) {
+ base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate) {
return new AppBannerDataFetcherDesktop(web_contents(), weak_delegate,
- ideal_icon_size);
+ kMinimumIconSize,
+ kMinimumIconSize);
}
AppBannerManagerDesktop::AppBannerManagerDesktop(
content::WebContents* web_contents)
- : AppBannerManager(web_contents, kMinimumIconSize) {
+ : AppBannerManager(web_contents) {
}
} // namespace banners
« no previous file with comments | « chrome/browser/banners/app_banner_manager_desktop.h ('k') | chrome/browser/manifest/manifest_icon_downloader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698