Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3021)

Unified Diff: chrome/browser/manifest/manifest_icon_downloader.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/manifest/manifest_icon_downloader.cc
diff --git a/chrome/browser/manifest/manifest_icon_downloader.cc b/chrome/browser/manifest/manifest_icon_downloader.cc
index b5a22bd80318de2a84b943bc746aadd502899b52..e1e8f4e3203b4ec15ad6cc5fe65ee4db9bd4db2d 100644
--- a/chrome/browser/manifest/manifest_icon_downloader.cc
+++ b/chrome/browser/manifest/manifest_icon_downloader.cc
@@ -16,6 +16,7 @@ bool ManifestIconDownloader::Download(
content::WebContents* web_contents,
const GURL& icon_url,
int ideal_icon_size_in_dp,
+ int minimum_icon_size_in_dp,
const ManifestIconDownloader::IconFetchCallback& callback) {
if (!web_contents || !icon_url.is_valid())
return false;
@@ -25,12 +26,10 @@ bool ManifestIconDownloader::Download(
const float device_scale_factor =
screen->GetPrimaryDisplay().device_scale_factor();
- const int ideal_icon_size_in_px =
- static_cast<int>(round(ideal_icon_size_in_dp * device_scale_factor));
-
- const float minimum_scale_factor = std::max(device_scale_factor - 1, 1.0f);
- const int minimum_icon_size_in_px =
- static_cast<int>(round(ideal_icon_size_in_dp * minimum_scale_factor));
+ const float ideal_icon_size_in_px =
+ ideal_icon_size_in_dp * device_scale_factor;
+ const float minimum_icon_size_in_px =
+ minimum_icon_size_in_dp * device_scale_factor;
web_contents->DownloadImage(
icon_url,

Powered by Google App Engine
This is Rietveld 408576698