chrome/browser/banners/app_banner_data_fetcher_browsertest.cc - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Address review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/shortcut_helper.cc ('K') | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_data_fetcher_desktop.h » ('j') | chrome/browser/manifest/manifest_icon_selector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

index 3b5979f1e6d9a14da02a75764225790f22e33d7f..ecc75c420268d9b79557d5ad534e0ce025e14b1f 100644

--- a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

@@ -94,7 +94,8 @@ class AppBannerDataFetcherBrowserTest : public InProcessBrowserTest,

browser()->tab_strip_model()->GetActiveWebContents();

scoped_refptr<AppBannerDataFetcherDesktop> fetcher(

new AppBannerDataFetcherDesktop(web_contents,

- weak_factory_.GetWeakPtr(), 128));

+ weak_factory_.GetWeakPtr(),

+ 128, 128));

base::RunLoop run_loop;

quit_closure_ = run_loop.QuitClosure();