Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5514)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index b4a7bf633a162d3c8d35a37bcd4a75c7e6cb79dc..e5d5bcc31ffc1e0f73737cec1f0d55ae0a9d31d9 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -27,11 +27,28 @@ class ShortcutHelper {
const std::string& webapp_id,
const SkBitmap& icon_bitmap);
+ // Gets the ideal size that the image displayed on the splash screen
+ // should be.
gone 2015/09/14 23:03:32 Doubly redundant. Doubly doubly redundant because
Lalit Maganti 2015/09/15 16:59:03 Changed all of these to be consistent with the Jav
+ static int GetIdealIconSizeInDp();
+
+ // Gets the minimum size that the image displayed on the splash screen
+ // should be.
+ static int GetMinimumIconSizeInDp();
+
+ // Gets the ideal size that the image displayed on the splash screen
+ // should be.
+ static int GetIdealSplashImageSizeInDp();
+
+ // Gets the minimum size that the image displayed on the splash screen
+ // should be.
+ static int GetMinimumSplashImageSizeInDp();
+
// Fetches the splash screen image and stores it inside the WebappDataStorage
// of the webapp.
static void FetchSplashScreenImage(content::WebContents* web_contents,
const GURL& image_url,
const int ideal_splash_image_size_in_dp,
+ const int minimum_splash_image_size_in_dp,
const std::string& webapp_id);
// Stores the data of the webapp which is not placed inside the shortcut.

Powered by Google App Engine
This is Rietveld 408576698