Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 9caa50eb07218140752acf6179c80fb7f43c4a46..0c70e083b0662b2f8a701009f241d4bd5dd638a8 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -9,6 +9,7 @@
#include "base/command_line.h"
#include "base/metrics/field_trial.h"
#include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
+#include "chrome/browser/android/shortcut_helper.h"
#include "chrome/browser/banners/app_banner_metrics.h"
#include "chrome/common/chrome_constants.h"
#include "content/public/browser/web_contents.h"
@@ -33,11 +34,8 @@ namespace banners {
AppBannerManagerAndroid::AppBannerManagerAndroid(
JNIEnv* env,
- jobject obj,
- int ideal_splash_image_size_in_dp,
- int ideal_icon_size_in_dp)
- : AppBannerManager(ideal_icon_size_in_dp),
- ideal_splash_image_size_in_dp_(ideal_splash_image_size_in_dp),
+ jobject obj)
+ : AppBannerManager(),
weak_java_banner_view_manager_(env, obj) {
}
@@ -93,9 +91,10 @@ bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
ConvertUTF8ToJavaString(env, id));
ScopedJavaLocalRef<jstring> jreferrer(
ConvertUTF8ToJavaString(env, referrer));
- Java_AppBannerManager_fetchAppDetails(env, jobj.obj(), jurl.obj(),
- jpackage.obj(), jreferrer.obj(),
- ideal_icon_size_in_dp());
+ Java_AppBannerManager_fetchAppDetails(
+ env, jobj.obj(), jurl.obj(),
+ jpackage.obj(), jreferrer.obj(),
+ ShortcutHelper::GetIdealIconSizeInDp());
return true;
}
@@ -143,11 +142,14 @@ std::string AppBannerManagerAndroid::ExtractQueryValueForName(
}
AppBannerDataFetcher* AppBannerManagerAndroid::CreateAppBannerDataFetcher(
- base::WeakPtr<Delegate> weak_delegate,
- const int ideal_icon_size_in_dp) {
- return new AppBannerDataFetcherAndroid(web_contents(), weak_delegate,
- ideal_splash_image_size_in_dp_,
- ideal_icon_size_in_dp);
+ base::WeakPtr<Delegate> weak_delegate) {
+ return new AppBannerDataFetcherAndroid(
+ web_contents(),
+ weak_delegate,
+ ShortcutHelper::GetIdealIconSizeInDp(),
+ ShortcutHelper::GetMinimumIconSizeInDp(),
+ ShortcutHelper::GetIdealSplashImageSizeInDp(),
+ ShortcutHelper::GetMinimumSplashImageSizeInDp());
}
bool AppBannerManagerAndroid::OnAppDetailsRetrieved(JNIEnv* env,
@@ -181,12 +183,8 @@ bool AppBannerManagerAndroid::Register(JNIEnv* env) {
}
jlong Init(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- jint ideal_splash_image_size_in_dp,
- jint ideal_icon_size_in_dp) {
- AppBannerManagerAndroid* manager =
- new AppBannerManagerAndroid(env, obj,
- ideal_splash_image_size_in_dp, ideal_icon_size_in_dp);
+ const JavaParamRef<jobject>& obj) {
+ AppBannerManagerAndroid* manager = new AppBannerManagerAndroid(env, obj);
return reinterpret_cast<intptr_t>(manager);
}

Powered by Google App Engine
This is Rietveld 408576698