chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java - Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon

Patch Set: Address review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.h » ('j') | chrome/browser/android/shortcut_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

index 5b0309a9981f0f85f633617a5c59c7516f5d9557..abeb06204847407a07f6c7f51bd8cab5f43b9f7a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

@@ -47,9 +47,7 @@ public class AddToHomescreenDialogHelper {

public void initialize(Observer observer) {

mObserver = observer;

mNativeAddToHomescreenDialogHelper = nativeInitialize(

- mTab.getWebContents(),

- ShortcutHelper.getIdealSplashImageSizeInDp(mAppContext.getResources()),

- ShortcutHelper.getIdealIconSizeInDp(mAppContext.getResources()));

+ mTab.getWebContents());

}

/**

@@ -100,8 +98,7 @@ public class AddToHomescreenDialogHelper {

ApplicationStatus.getApplicationContext(), icon, url, red, green, blue);

}

- private native long nativeInitialize(WebContents webContents,

- int idealSplashImageSizeInDp, int idealIconSizeInDp);

+ private native long nativeInitialize(WebContents webContents);

private native void nativeAddShortcut(long nativeAddToHomescreenDialogHelper,

String userRequestedTitle);

private native void nativeDestroy(long nativeAddToHomescreenDialogHelper);