Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Side by Side Diff: chrome/browser/manifest/manifest_icon_selector.cc

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Fix non-compiling test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/manifest/manifest_icon_selector.h" 5 #include "chrome/browser/manifest/manifest_icon_selector.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <limits> 9 #include <limits>
10 10
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 } 157 }
158 } 158 }
159 159
160 return result; 160 return result;
161 } 161 }
162 162
163 // static 163 // static
164 GURL ManifestIconSelector::FindBestMatchingIcon( 164 GURL ManifestIconSelector::FindBestMatchingIcon(
165 const std::vector<Manifest::Icon>& unfiltered_icons, 165 const std::vector<Manifest::Icon>& unfiltered_icons,
166 const float preferred_icon_size_in_dp, 166 const float preferred_icon_size_in_dp,
167 const float minimum_icon_size_in_dp,
167 const gfx::Screen* screen) { 168 const gfx::Screen* screen) {
168 const float device_scale_factor = 169 const float device_scale_factor =
169 screen->GetPrimaryDisplay().device_scale_factor(); 170 screen->GetPrimaryDisplay().device_scale_factor();
170 const float preferred_icon_size_in_pixels = 171 const float preferred_icon_size_in_pixels =
171 preferred_icon_size_in_dp * device_scale_factor; 172 preferred_icon_size_in_dp * device_scale_factor;
172
173 const int minimum_scale_factor = std::max(
174 static_cast<int>(floor(device_scale_factor - 1)), 1);
175 const float minimum_icon_size_in_pixels = 173 const float minimum_icon_size_in_pixels =
176 preferred_icon_size_in_dp * minimum_scale_factor; 174 minimum_icon_size_in_dp * device_scale_factor;
177 175
178 std::vector<Manifest::Icon> icons = 176 std::vector<Manifest::Icon> icons =
179 ManifestIconSelector::FilterIconsByType(unfiltered_icons); 177 ManifestIconSelector::FilterIconsByType(unfiltered_icons);
180 178
181 ManifestIconSelector selector(preferred_icon_size_in_pixels, 179 ManifestIconSelector selector(preferred_icon_size_in_pixels,
182 minimum_icon_size_in_pixels); 180 minimum_icon_size_in_pixels);
183 int index = selector.FindBestMatchingIcon(icons, device_scale_factor); 181 int index = selector.FindBestMatchingIcon(icons, device_scale_factor);
184 if (index == -1) 182 if (index == -1)
185 return GURL(); 183 return GURL();
186 return icons[index].src; 184 return icons[index].src;
187 } 185 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698