Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3242)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 1307093004: Remove references to IsNewAvatarMenu since the flag was removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index 713f62c840795a243d3e64c9ffc2e2a20e0c38a5..926c6e02a57b73620a577591316ed5cb1db8fcbc 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -75,24 +75,15 @@ void LoginUIService::ShowLoginPopup() {
void LoginUIService::DisplayLoginResult(Browser* browser,
const base::string16& message) {
- last_login_result_ = message;
- if (switches::IsNewAvatarMenu()) {
- browser->window()->ShowAvatarBubbleFromAvatarButton(
- message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN :
- BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,
- signin::ManageAccountsParams());
- } else {
-#if defined(ENABLE_ONE_CLICK_SIGNIN)
- browser->window()->ShowOneClickSigninBubble(
- BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE,
- base::string16(), /* no SAML email */
- message,
- // This callback is never invoked.
- // TODO(rogerta): Separate out the bubble API so we don't have to pass
- // ignored |email| and |callback| params.
- BrowserWindow::StartSyncCallback());
+#if defined(OS_CHROMEOS)
+ // ChromeOS doesn't have the avatar bubble so it never calls this function.
+ NOTREACHED();
#endif
- }
+ last_login_result_ = message;
+ browser->window()->ShowAvatarBubbleFromAvatarButton(
+ message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN :
+ BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,
+ signin::ManageAccountsParams());
}
const base::string16& LoginUIService::GetLastLoginResult() {

Powered by Google App Engine
This is Rietveld 408576698