Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: chrome/browser/resources/options/manage_profile_overlay.js

Issue 1307093004: Remove references to IsNewAvatarMenu since the flag was removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_window_browsertest.cc ('k') | chrome/browser/signin/signin_global_error.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/manage_profile_overlay.js
diff --git a/chrome/browser/resources/options/manage_profile_overlay.js b/chrome/browser/resources/options/manage_profile_overlay.js
index 5b3e41f813d011ed486966b84ef780cd20e6ce67..1f806422acec0b2383127374999ab1dd099283e3 100644
--- a/chrome/browser/resources/options/manage_profile_overlay.js
+++ b/chrome/browser/resources/options/manage_profile_overlay.js
@@ -95,25 +95,11 @@ cr.define('options', function() {
$('create-profile-supervised-sign-in-link').onclick =
function(event) {
- // Without the new avatar menu, the signin process will open an overlay
- // to configure sync, which would replace this overlay. It's smoother to
- // close this one now.
- // With the new avatar menu enabled, a sign-in flow in the avatar menu
- // is triggered instead, which does not open any overlays, so there's no
- // need to close this one.
- if (!loadTimeData.getBoolean('newAvatarMenuEnabled')) {
- // TODO(pamg): Move the sync-setup overlay to a higher layer so this
- // one can stay open under it, after making sure that doesn't break
- // anything else.
- PageManager.closeOverlay();
- }
SyncSetupOverlay.startSignIn();
};
$('create-profile-supervised-sign-in-again-link').onclick =
function(event) {
- if (!loadTimeData.getBoolean('newAvatarMenuEnabled'))
- PageManager.closeOverlay();
SyncSetupOverlay.showSetupUI();
};
« no previous file with comments | « chrome/browser/profiles/profile_window_browsertest.cc ('k') | chrome/browser/signin/signin_global_error.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698