Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 1307013004: Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move setSandboxFlags call Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebLocalFrame.h
diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h
index 44bace909f42b7733895f321970c88a94a52aa2e..9f565932b5da2660e4c932205473cabfcd52f5d4 100644
--- a/third_party/WebKit/public/web/WebLocalFrame.h
+++ b/third_party/WebKit/public/web/WebLocalFrame.h
@@ -52,13 +52,22 @@ public:
// Used when we might swap from a remote frame to a local frame.
// Creates a provisional, semi-attached frame that will be fully
// swapped into the frame tree if it commits.
- virtual void initializeToReplaceRemoteFrame(WebRemoteFrame*, const WebString& name, WebSandboxFlags) = 0;
+ virtual void initializeToReplaceRemoteFrame(WebRemoteFrame*, const WebString& name, WebSandboxFlags, const WebFrameOwnerProperties&) = 0;
virtual void setAutofillClient(WebAutofillClient*) = 0;
virtual WebAutofillClient* autofillClient() = 0;
virtual void setDevToolsAgentClient(WebDevToolsAgentClient*) = 0;
virtual WebDevToolsAgent* devToolsAgent() = 0;
+ // Basic properties ---------------------------------------------------
+
+ // Updates the scrolling and margin properties in the frame's FrameOwner.
+ // This is used when this frame's parent is in another process and it
+ // dynamically updates these properties.
+ // TODO(dcheng): Currently, the update only takes effect on next frame
dcheng 2015/10/21 21:04:01 What's this TODO for? =)
lazyboy 2015/10/23 21:19:35 This corresponds to the FIXMEs in https://coderev
+ // navigation. This matches the in-process frame behavior.
+ virtual void setFrameOwnerProperties(const WebFrameOwnerProperties&) = 0;
+
// Navigation Ping --------------------------------------------------------
virtual void sendPings(const WebNode& contextNode, const WebURL& destinationURL) = 0;

Powered by Google App Engine
This is Rietveld 408576698