Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1307013004: Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: consolidate render->browser ipcs into one Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 18463b35513168e1b4f6ed0bf80ad61bc9e555ce..837235f0c4ab38d3cb09d69e409628cc667ffdca 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -15,6 +15,7 @@
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
+#include "content/browser/bad_message.h"
#include "content/browser/site_instance_impl.h"
#include "content/common/accessibility_mode_enums.h"
#include "content/common/ax_content_node_data.h"
@@ -27,6 +28,7 @@
#include "content/public/browser/render_frame_host.h"
#include "content/public/common/javascript_message_type.h"
#include "net/http/http_response_headers.h"
+#include "third_party/WebKit/public/web/WebFrameOwnerProperties.h"
#include "third_party/WebKit/public/web/WebTextDirection.h"
#include "third_party/WebKit/public/web/WebTreeScopeType.h"
#include "ui/accessibility/ax_node_data.h"
@@ -203,10 +205,12 @@ class CONTENT_EXPORT RenderFrameHostImpl
void Init();
int routing_id() const { return routing_id_; }
- void OnCreateChildFrame(int new_routing_id,
- blink::WebTreeScopeType scope,
- const std::string& frame_name,
- blink::WebSandboxFlags sandbox_flags);
+ void OnCreateChildFrame(
+ int new_routing_id,
+ blink::WebTreeScopeType scope,
+ const std::string& frame_name,
+ blink::WebSandboxFlags sandbox_flags,
+ const blink::WebFrameOwnerProperties& frame_owner_properties);
RenderViewHostImpl* render_view_host() { return render_view_host_; }
RenderFrameHostDelegate* delegate() { return delegate_; }
@@ -248,6 +252,8 @@ class CONTENT_EXPORT RenderFrameHostImpl
// TODO(creis): Make bindings frame-specific, to support cases like <webview>.
int GetEnabledBindings();
+ void DidChangeChildFrameOwnerProperties(FrameTreeNode* child);
+
NavigationHandleImpl* navigation_handle() const {
return navigation_handle_.get();
}
@@ -539,6 +545,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
void OnDidAssignPageId(int32 page_id);
void OnDidChangeSandboxFlags(int32 frame_routing_id,
blink::WebSandboxFlags flags);
+ void OnDidChangeFrameOwnerProperties(
+ int32 frame_routing_id,
+ const blink::WebFrameOwnerProperties& frame_owner_properties);
void OnUpdateTitle(const base::string16& title,
blink::WebTextDirection title_direction);
void OnUpdateEncoding(const std::string& encoding);
@@ -606,6 +615,12 @@ class CONTENT_EXPORT RenderFrameHostImpl
void AXContentNodeDataToAXNodeData(const AXContentNodeData& src,
ui::AXNodeData* dst);
+ // Returns the child FrameTreeNode if |child_frame_routing_id| is an
+ // immediate child of this FrameTreeNode. Kills this renderer otherwise
+ // with bad message |reason|.
+ FrameTreeNode* CheckAndGetIfImmediateChild(
alexmos 2015/09/21 18:53:22 Maybe this fits better in the anonymous namespace
lazyboy 2015/09/22 02:38:54 I still need |this|, do you mean to also pass that
alexmos 2015/09/22 16:56:52 Ah, right. It's fine to keep it where it is then.
+ int32 child_frame_routing_id, bad_message::BadMessageReason reason);
+
// For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
// refcount that calls Shutdown when it reaches zero. This allows each
// RenderFrameHostManager to just care about RenderFrameHosts, while ensuring

Powered by Google App Engine
This is Rietveld 408576698