Propagate scrolling/marginwidth/marginheight property values to child frame.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 227 matching lines @@
 using blink::WebUserGestureIndicator;
 using blink::WebVector;
 using blink::WebView;
 using base::Time;
 using base::TimeDelta;
 
 namespace content {
 
 namespace {
 
+int GetRoutingIDForFrame(blink::WebFrame* child_frame) {
+  if (child_frame->isWebRemoteFrame())
+    return RenderFrameProxy::FromWebFrame(child_frame)->routing_id();
+
+  return RenderFrameImpl::FromWebFrame(child_frame)->GetRoutingID();
+}
+
 const char kDefaultAcceptHeader[] =
     "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/"
     "*;q=0.8";
 const char kAcceptHeader[] = "Accept";
 
 const size_t kExtraCharsBeforeAndAfterSelection = 100;
 
 typedef std::map<int, RenderFrameImpl*> RoutingIDFrameMap;
 static base::LazyInstance<RoutingIDFrameMap> g_routing_id_frame_map =
     LAZY_INSTANCE_INITIALIZER;
@@ skipping 320 matching lines @@
 }
 
 // static
 void RenderFrameImpl::CreateFrame(
     int routing_id,
     int parent_routing_id,
     int previous_sibling_routing_id,
     int proxy_routing_id,
     const FrameReplicationState& replicated_state,
     CompositorDependencies* compositor_deps,
-    const FrameMsg_NewFrame_WidgetParams& widget_params) {
+    const FrameMsg_NewFrame_WidgetParams& widget_params,
+    const blink::WebFrameOwnerProperties& frame_owner_properties) {
   blink::WebLocalFrame* web_frame;
   RenderFrameImpl* render_frame;
   if (proxy_routing_id == MSG_ROUTING_NONE) {
     RenderFrameProxy* parent_proxy =
         RenderFrameProxy::FromRoutingID(parent_routing_id);
     // If the browser is sending a valid parent routing id, it should already
     // be created and registered.
     CHECK(parent_proxy);
     blink::WebRemoteFrame* parent_web_frame = parent_proxy->web_frame();
 
     blink::WebFrame* previous_sibling_web_frame = nullptr;
     RenderFrameProxy* previous_sibling_proxy =
         RenderFrameProxy::FromRoutingID(previous_sibling_routing_id);
     if (previous_sibling_proxy)
       previous_sibling_web_frame = previous_sibling_proxy->web_frame();
 
     // Create the RenderFrame and WebLocalFrame, linking the two.
     render_frame =
         RenderFrameImpl::Create(parent_proxy->render_view(), routing_id);
     web_frame = parent_web_frame->createLocalChild(
         replicated_state.scope, WebString::fromUTF8(replicated_state.name),
         replicated_state.sandbox_flags, render_frame,
         previous_sibling_web_frame);
+    web_frame->setFrameOwnerProperties(frame_owner_properties);

[alexmos, 2015/09/02 21:42:09]

This will transfer updated properties for cross-site frame navigations, but what
about same-site frame navigations?  I.e., how will this work: A embeds B, A
updates margins, B navigates to B2.  B2 presumably needs to use the updated
margins, but I don't see how that would work, since you don't forward the
updates right away in your new OnDidChange* functions.

[lazyboy, 2015/09/15 19:30:56]

You're right, this case didn't use to work.
since you don't forward the
I've started to send the updates right away in OnDidChange* functions.

   } else {
     RenderFrameProxy* proxy =
         RenderFrameProxy::FromRoutingID(proxy_routing_id);
     CHECK(proxy);
     render_frame = RenderFrameImpl::Create(proxy->render_view(), routing_id);
     web_frame =
         blink::WebLocalFrame::create(replicated_state.scope, render_frame);
     render_frame->proxy_routing_id_ = proxy_routing_id;
     web_frame->initializeToReplaceRemoteFrame(

[alexmos, 2015/09/02 21:42:09]

This remote-to-local path might need to call setFrameOwnerProperties as well. 
For example, if you have A-embed-B-embed-C, B updates the properties, and C
navigates to A, it will need the latest properties here, right?  Would be good
to have a test for this eventually.

[lazyboy, 2015/09/15 19:30:56]

Done.

         proxy->web_frame(), WebString::fromUTF8(replicated_state.name),
         replicated_state.sandbox_flags);
   }
   render_frame->SetWebFrame(web_frame);
   CHECK_IMPLIES(parent_routing_id == MSG_ROUTING_NONE, !web_frame->parent());
 
   if (widget_params.routing_id != MSG_ROUTING_NONE) {
     CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible());
     render_frame->render_widget_ = RenderWidget::CreateForFrame(
         widget_params.routing_id, widget_params.surface_id,
@@ skipping 1559 matching lines @@
     if (!navigation_state->request_committed()) {
       Send(new FrameHostMsg_DidAccessInitialDocument(routing_id_));
     }
   }
 }
 
 blink::WebFrame* RenderFrameImpl::createChildFrame(
     blink::WebLocalFrame* parent,
     blink::WebTreeScopeType scope,
     const blink::WebString& name,
-    blink::WebSandboxFlags sandbox_flags) {
+    blink::WebSandboxFlags sandbox_flags,
+    const blink::WebFrameOwnerProperties& frameOwnerProperties) {
   // Synchronously notify the browser of a child frame creation to get the
   // routing_id for the RenderFrame.
   int child_routing_id = MSG_ROUTING_NONE;
   Send(new FrameHostMsg_CreateChildFrame(
-      routing_id_, scope,
-      base::UTF16ToUTF8(base::StringPiece16(name)), sandbox_flags,
-      &child_routing_id));
+      routing_id_, scope, base::UTF16ToUTF8(base::StringPiece16(name)),
+      sandbox_flags, frameOwnerProperties, &child_routing_id));
 
   // Allocation of routing id failed, so we can't create a child frame. This can
   // happen if this RenderFrameImpl's IPCs are being filtered when in swapped
   // out state or synchronous IPC message above has failed.
   if (child_routing_id == MSG_ROUTING_NONE) {
     NOTREACHED() << "Failed to allocate routing id for child frame.";
     return nullptr;
   }
 
   // Create the RenderFrame and WebLocalFrame, linking the two.
@@ skipping 102 matching lines @@
   // updates are happening too frequently.
   if (SiteIsolationPolicy::AreCrossProcessFramesPossible() ||
       render_view_->renderer_preferences_.report_frame_name_changes) {
     Send(new FrameHostMsg_DidChangeName(
         routing_id_, base::UTF16ToUTF8(base::StringPiece16(name))));
   }
 }
 
 void RenderFrameImpl::didChangeSandboxFlags(blink::WebFrame* child_frame,
                                             blink::WebSandboxFlags flags) {
-  int frame_routing_id = MSG_ROUTING_NONE;
-  if (child_frame->isWebRemoteFrame()) {
-    frame_routing_id =
-        RenderFrameProxy::FromWebFrame(child_frame)->routing_id();
-  } else {
-    frame_routing_id =
-        RenderFrameImpl::FromWebFrame(child_frame)->GetRoutingID();
-  }
-
+  int frame_routing_id = GetRoutingIDForFrame(child_frame);
   Send(new FrameHostMsg_DidChangeSandboxFlags(routing_id_, frame_routing_id,
                                               flags));
 }
 
+void RenderFrameImpl::didChangeScrollingMode(
+    blink::WebFrame* child_frame,
+    blink::WebFrameOwnerProperties::ScrollingMode scrolling_mode) {
+  int frame_routing_id = GetRoutingIDForFrame(child_frame);
+  Send(new FrameHostMsg_DidChangeScrollingMode(routing_id_, frame_routing_id,
+                                               scrolling_mode));
+}
+
+void RenderFrameImpl::didChangeMarginWidth(blink::WebFrame* child_frame,
+                                           int marginWidth) {
+  int frame_routing_id = GetRoutingIDForFrame(child_frame);
+  Send(new FrameHostMsg_DidChangeMarginWidth(routing_id_, frame_routing_id,
+                                             marginWidth));
+}
+
+void RenderFrameImpl::didChangeMarginHeight(blink::WebFrame* child_frame,
+                                            int marginHeight) {
+  int frame_routing_id = GetRoutingIDForFrame(child_frame);
+  Send(new FrameHostMsg_DidChangeMarginHeight(routing_id_, frame_routing_id,
+                                              marginHeight));
+}
+
 void RenderFrameImpl::didMatchCSS(
     blink::WebLocalFrame* frame,
     const blink::WebVector<blink::WebString>& newly_matching_selectors,
     const blink::WebVector<blink::WebString>& stopped_matching_selectors) {
   DCHECK(!frame_ || frame_ == frame);
 
   FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
                     DidMatchCSS(newly_matching_selectors,
                                 stopped_matching_selectors));
 }
@@ skipping 2755 matching lines @@
     GetServiceRegistry()->ConnectToRemoteService(mojo::GetProxy(&mojo_shell_));
   mojo::ServiceProviderPtr service_provider;
   mojo::URLRequestPtr request(mojo::URLRequest::New());
   request->url = mojo::String::From(url);
   mojo_shell_->ConnectToApplication(request.Pass(), GetProxy(&service_provider),
                                     nullptr, nullptr);
   return service_provider.Pass();
 }
 
 }  // namespace content