Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 1307013004: Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 using blink::WebUserGestureIndicator; 240 using blink::WebUserGestureIndicator;
241 using blink::WebVector; 241 using blink::WebVector;
242 using blink::WebView; 242 using blink::WebView;
243 using base::Time; 243 using base::Time;
244 using base::TimeDelta; 244 using base::TimeDelta;
245 245
246 namespace content { 246 namespace content {
247 247
248 namespace { 248 namespace {
249 249
250 int GetRoutingIDForFrame(blink::WebFrame* child_frame) {
251 if (child_frame->isWebRemoteFrame())
252 return RenderFrameProxy::FromWebFrame(child_frame)->routing_id();
253
254 return RenderFrameImpl::FromWebFrame(child_frame)->GetRoutingID();
255 }
256
250 const char kDefaultAcceptHeader[] = 257 const char kDefaultAcceptHeader[] =
251 "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/" 258 "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/"
252 "*;q=0.8"; 259 "*;q=0.8";
253 const char kAcceptHeader[] = "Accept"; 260 const char kAcceptHeader[] = "Accept";
254 261
255 const size_t kExtraCharsBeforeAndAfterSelection = 100; 262 const size_t kExtraCharsBeforeAndAfterSelection = 100;
256 263
257 typedef std::map<int, RenderFrameImpl*> RoutingIDFrameMap; 264 typedef std::map<int, RenderFrameImpl*> RoutingIDFrameMap;
258 static base::LazyInstance<RoutingIDFrameMap> g_routing_id_frame_map = 265 static base::LazyInstance<RoutingIDFrameMap> g_routing_id_frame_map =
259 LAZY_INSTANCE_INITIALIZER; 266 LAZY_INSTANCE_INITIALIZER;
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 563
557 // static 564 // static
558 void RenderFrameImpl::CreateFrame( 565 void RenderFrameImpl::CreateFrame(
559 int routing_id, 566 int routing_id,
560 int proxy_routing_id, 567 int proxy_routing_id,
561 int opener_routing_id, 568 int opener_routing_id,
562 int parent_routing_id, 569 int parent_routing_id,
563 int previous_sibling_routing_id, 570 int previous_sibling_routing_id,
564 const FrameReplicationState& replicated_state, 571 const FrameReplicationState& replicated_state,
565 CompositorDependencies* compositor_deps, 572 CompositorDependencies* compositor_deps,
566 const FrameMsg_NewFrame_WidgetParams& widget_params) { 573 const FrameMsg_NewFrame_WidgetParams& widget_params,
574 const blink::WebFrameOwnerProperties& frame_owner_properties) {
567 blink::WebLocalFrame* web_frame; 575 blink::WebLocalFrame* web_frame;
568 RenderFrameImpl* render_frame; 576 RenderFrameImpl* render_frame;
569 if (proxy_routing_id == MSG_ROUTING_NONE) { 577 if (proxy_routing_id == MSG_ROUTING_NONE) {
570 RenderFrameProxy* parent_proxy = 578 RenderFrameProxy* parent_proxy =
571 RenderFrameProxy::FromRoutingID(parent_routing_id); 579 RenderFrameProxy::FromRoutingID(parent_routing_id);
572 // If the browser is sending a valid parent routing id, it should already 580 // If the browser is sending a valid parent routing id, it should already
573 // be created and registered. 581 // be created and registered.
574 CHECK(parent_proxy); 582 CHECK(parent_proxy);
575 blink::WebRemoteFrame* parent_web_frame = parent_proxy->web_frame(); 583 blink::WebRemoteFrame* parent_web_frame = parent_proxy->web_frame();
576 584
577 blink::WebFrame* previous_sibling_web_frame = nullptr; 585 blink::WebFrame* previous_sibling_web_frame = nullptr;
578 RenderFrameProxy* previous_sibling_proxy = 586 RenderFrameProxy* previous_sibling_proxy =
579 RenderFrameProxy::FromRoutingID(previous_sibling_routing_id); 587 RenderFrameProxy::FromRoutingID(previous_sibling_routing_id);
580 if (previous_sibling_proxy) 588 if (previous_sibling_proxy)
581 previous_sibling_web_frame = previous_sibling_proxy->web_frame(); 589 previous_sibling_web_frame = previous_sibling_proxy->web_frame();
582 590
583 // Create the RenderFrame and WebLocalFrame, linking the two. 591 // Create the RenderFrame and WebLocalFrame, linking the two.
584 render_frame = 592 render_frame =
585 RenderFrameImpl::Create(parent_proxy->render_view(), routing_id); 593 RenderFrameImpl::Create(parent_proxy->render_view(), routing_id);
586 web_frame = parent_web_frame->createLocalChild( 594 web_frame = parent_web_frame->createLocalChild(
587 replicated_state.scope, WebString::fromUTF8(replicated_state.name), 595 replicated_state.scope, WebString::fromUTF8(replicated_state.name),
588 replicated_state.sandbox_flags, render_frame, 596 replicated_state.sandbox_flags, render_frame,
589 previous_sibling_web_frame); 597 previous_sibling_web_frame, frame_owner_properties);
590 } else { 598 } else {
591 RenderFrameProxy* proxy = 599 RenderFrameProxy* proxy =
592 RenderFrameProxy::FromRoutingID(proxy_routing_id); 600 RenderFrameProxy::FromRoutingID(proxy_routing_id);
593 CHECK(proxy); 601 CHECK(proxy);
594 render_frame = RenderFrameImpl::Create(proxy->render_view(), routing_id); 602 render_frame = RenderFrameImpl::Create(proxy->render_view(), routing_id);
595 web_frame = 603 web_frame =
596 blink::WebLocalFrame::create(replicated_state.scope, render_frame); 604 blink::WebLocalFrame::create(replicated_state.scope, render_frame);
597 render_frame->proxy_routing_id_ = proxy_routing_id; 605 render_frame->proxy_routing_id_ = proxy_routing_id;
598 web_frame->initializeToReplaceRemoteFrame( 606 web_frame->initializeToReplaceRemoteFrame(
599 proxy->web_frame(), WebString::fromUTF8(replicated_state.name), 607 proxy->web_frame(), WebString::fromUTF8(replicated_state.name),
600 replicated_state.sandbox_flags); 608 replicated_state.sandbox_flags, frame_owner_properties);
601 } 609 }
602 render_frame->SetWebFrame(web_frame); 610 render_frame->SetWebFrame(web_frame);
603 CHECK_IMPLIES(parent_routing_id == MSG_ROUTING_NONE, !web_frame->parent()); 611 CHECK_IMPLIES(parent_routing_id == MSG_ROUTING_NONE, !web_frame->parent());
604 612
605 WebFrame* opener = ResolveOpener(opener_routing_id, nullptr); 613 WebFrame* opener = ResolveOpener(opener_routing_id, nullptr);
606 web_frame->setOpener(opener); 614 web_frame->setOpener(opener);
607 615
608 if (widget_params.routing_id != MSG_ROUTING_NONE) { 616 if (widget_params.routing_id != MSG_ROUTING_NONE) {
609 CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible()); 617 CHECK(SiteIsolationPolicy::AreCrossProcessFramesPossible());
610 render_frame->render_widget_ = RenderWidget::CreateForFrame( 618 render_frame->render_widget_ = RenderWidget::CreateForFrame(
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
1094 IPC_MESSAGE_HANDLER(FrameMsg_Reload, OnReload) 1102 IPC_MESSAGE_HANDLER(FrameMsg_Reload, OnReload)
1095 IPC_MESSAGE_HANDLER(FrameMsg_TextSurroundingSelectionRequest, 1103 IPC_MESSAGE_HANDLER(FrameMsg_TextSurroundingSelectionRequest,
1096 OnTextSurroundingSelectionRequest) 1104 OnTextSurroundingSelectionRequest)
1097 IPC_MESSAGE_HANDLER(FrameMsg_SetAccessibilityMode, 1105 IPC_MESSAGE_HANDLER(FrameMsg_SetAccessibilityMode,
1098 OnSetAccessibilityMode) 1106 OnSetAccessibilityMode)
1099 IPC_MESSAGE_HANDLER(AccessibilityMsg_SnapshotTree, 1107 IPC_MESSAGE_HANDLER(AccessibilityMsg_SnapshotTree,
1100 OnSnapshotAccessibilityTree) 1108 OnSnapshotAccessibilityTree)
1101 IPC_MESSAGE_HANDLER(FrameMsg_UpdateOpener, OnUpdateOpener) 1109 IPC_MESSAGE_HANDLER(FrameMsg_UpdateOpener, OnUpdateOpener)
1102 IPC_MESSAGE_HANDLER(FrameMsg_CommitNavigation, OnCommitNavigation) 1110 IPC_MESSAGE_HANDLER(FrameMsg_CommitNavigation, OnCommitNavigation)
1103 IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateSandboxFlags, OnDidUpdateSandboxFlags) 1111 IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateSandboxFlags, OnDidUpdateSandboxFlags)
1112 IPC_MESSAGE_HANDLER(FrameMsg_SetFrameOwnerProperties,
1113 OnSetFrameOwnerProperties)
1104 IPC_MESSAGE_HANDLER(FrameMsg_SetTextTrackSettings, 1114 IPC_MESSAGE_HANDLER(FrameMsg_SetTextTrackSettings,
1105 OnTextTrackSettingsChanged) 1115 OnTextTrackSettingsChanged)
1106 IPC_MESSAGE_HANDLER(FrameMsg_PostMessageEvent, OnPostMessageEvent) 1116 IPC_MESSAGE_HANDLER(FrameMsg_PostMessageEvent, OnPostMessageEvent)
1107 IPC_MESSAGE_HANDLER(FrameMsg_FailedNavigation, OnFailedNavigation) 1117 IPC_MESSAGE_HANDLER(FrameMsg_FailedNavigation, OnFailedNavigation)
1108 IPC_MESSAGE_HANDLER(FrameMsg_GetSavableResourceLinks, 1118 IPC_MESSAGE_HANDLER(FrameMsg_GetSavableResourceLinks,
1109 OnGetSavableResourceLinks) 1119 OnGetSavableResourceLinks)
1110 #if defined(OS_ANDROID) 1120 #if defined(OS_ANDROID)
1111 IPC_MESSAGE_HANDLER(FrameMsg_SelectPopupMenuItems, OnSelectPopupMenuItems) 1121 IPC_MESSAGE_HANDLER(FrameMsg_SelectPopupMenuItems, OnSelectPopupMenuItems)
1112 #elif defined(OS_MACOSX) 1122 #elif defined(OS_MACOSX)
1113 IPC_MESSAGE_HANDLER(FrameMsg_SelectPopupMenuItem, OnSelectPopupMenuItem) 1123 IPC_MESSAGE_HANDLER(FrameMsg_SelectPopupMenuItem, OnSelectPopupMenuItem)
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
1648 1658
1649 void RenderFrameImpl::OnUpdateOpener(int opener_routing_id) { 1659 void RenderFrameImpl::OnUpdateOpener(int opener_routing_id) {
1650 WebFrame* opener = ResolveOpener(opener_routing_id, nullptr); 1660 WebFrame* opener = ResolveOpener(opener_routing_id, nullptr);
1651 frame_->setOpener(opener); 1661 frame_->setOpener(opener);
1652 } 1662 }
1653 1663
1654 void RenderFrameImpl::OnDidUpdateSandboxFlags(blink::WebSandboxFlags flags) { 1664 void RenderFrameImpl::OnDidUpdateSandboxFlags(blink::WebSandboxFlags flags) {
1655 frame_->setFrameOwnerSandboxFlags(flags); 1665 frame_->setFrameOwnerSandboxFlags(flags);
1656 } 1666 }
1657 1667
1668 void RenderFrameImpl::OnSetFrameOwnerProperties(
1669 const blink::WebFrameOwnerProperties& frame_owner_properties) {
1670 DCHECK(frame_);
1671 frame_->setFrameOwnerProperties(frame_owner_properties);
1672 }
1673
1658 void RenderFrameImpl::OnTextTrackSettingsChanged( 1674 void RenderFrameImpl::OnTextTrackSettingsChanged(
1659 const FrameMsg_TextTrackSettings_Params& params) { 1675 const FrameMsg_TextTrackSettings_Params& params) {
1660 DCHECK(!frame_->parent()); 1676 DCHECK(!frame_->parent());
1661 if (!render_view_->webview()) 1677 if (!render_view_->webview())
1662 return; 1678 return;
1663 1679
1664 if (params.text_tracks_enabled) { 1680 if (params.text_tracks_enabled) {
1665 render_view_->webview()->settings()->setTextTrackKindUserPreference( 1681 render_view_->webview()->settings()->setTextTrackKindUserPreference(
1666 WebSettings::TextTrackKindUserPreference::Captions); 1682 WebSettings::TextTrackKindUserPreference::Captions);
1667 } else { 1683 } else {
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
2181 if (!navigation_state->request_committed()) { 2197 if (!navigation_state->request_committed()) {
2182 Send(new FrameHostMsg_DidAccessInitialDocument(routing_id_)); 2198 Send(new FrameHostMsg_DidAccessInitialDocument(routing_id_));
2183 } 2199 }
2184 } 2200 }
2185 } 2201 }
2186 2202
2187 blink::WebFrame* RenderFrameImpl::createChildFrame( 2203 blink::WebFrame* RenderFrameImpl::createChildFrame(
2188 blink::WebLocalFrame* parent, 2204 blink::WebLocalFrame* parent,
2189 blink::WebTreeScopeType scope, 2205 blink::WebTreeScopeType scope,
2190 const blink::WebString& name, 2206 const blink::WebString& name,
2191 blink::WebSandboxFlags sandbox_flags) { 2207 blink::WebSandboxFlags sandbox_flags,
2208 const blink::WebFrameOwnerProperties& frameOwnerProperties) {
2192 // Synchronously notify the browser of a child frame creation to get the 2209 // Synchronously notify the browser of a child frame creation to get the
2193 // routing_id for the RenderFrame. 2210 // routing_id for the RenderFrame.
2194 int child_routing_id = MSG_ROUTING_NONE; 2211 int child_routing_id = MSG_ROUTING_NONE;
2195 Send(new FrameHostMsg_CreateChildFrame( 2212 Send(new FrameHostMsg_CreateChildFrame(
2196 routing_id_, scope, 2213 routing_id_, scope, base::UTF16ToUTF8(base::StringPiece16(name)),
2197 base::UTF16ToUTF8(base::StringPiece16(name)), sandbox_flags, 2214 sandbox_flags, frameOwnerProperties, &child_routing_id));
2198 &child_routing_id));
2199 2215
2200 // Allocation of routing id failed, so we can't create a child frame. This can 2216 // Allocation of routing id failed, so we can't create a child frame. This can
2201 // happen if this RenderFrameImpl's IPCs are being filtered when in swapped 2217 // happen if this RenderFrameImpl's IPCs are being filtered when in swapped
2202 // out state or synchronous IPC message above has failed. 2218 // out state or synchronous IPC message above has failed.
2203 if (child_routing_id == MSG_ROUTING_NONE) { 2219 if (child_routing_id == MSG_ROUTING_NONE) {
2204 NOTREACHED() << "Failed to allocate routing id for child frame."; 2220 NOTREACHED() << "Failed to allocate routing id for child frame.";
2205 return nullptr; 2221 return nullptr;
2206 } 2222 }
2207 2223
2208 // Create the RenderFrame and WebLocalFrame, linking the two. 2224 // Create the RenderFrame and WebLocalFrame, linking the two.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
2311 // updates are happening too frequently. 2327 // updates are happening too frequently.
2312 if (SiteIsolationPolicy::AreCrossProcessFramesPossible() || 2328 if (SiteIsolationPolicy::AreCrossProcessFramesPossible() ||
2313 render_view_->renderer_preferences_.report_frame_name_changes) { 2329 render_view_->renderer_preferences_.report_frame_name_changes) {
2314 Send(new FrameHostMsg_DidChangeName( 2330 Send(new FrameHostMsg_DidChangeName(
2315 routing_id_, base::UTF16ToUTF8(base::StringPiece16(name)))); 2331 routing_id_, base::UTF16ToUTF8(base::StringPiece16(name))));
2316 } 2332 }
2317 } 2333 }
2318 2334
2319 void RenderFrameImpl::didChangeSandboxFlags(blink::WebFrame* child_frame, 2335 void RenderFrameImpl::didChangeSandboxFlags(blink::WebFrame* child_frame,
2320 blink::WebSandboxFlags flags) { 2336 blink::WebSandboxFlags flags) {
2321 int frame_routing_id = MSG_ROUTING_NONE; 2337 int frame_routing_id = GetRoutingIDForFrame(child_frame);
2322 if (child_frame->isWebRemoteFrame()) {
2323 frame_routing_id =
2324 RenderFrameProxy::FromWebFrame(child_frame)->routing_id();
2325 } else {
2326 frame_routing_id =
2327 RenderFrameImpl::FromWebFrame(child_frame)->GetRoutingID();
2328 }
2329
2330 Send(new FrameHostMsg_DidChangeSandboxFlags(routing_id_, frame_routing_id, 2338 Send(new FrameHostMsg_DidChangeSandboxFlags(routing_id_, frame_routing_id,
2331 flags)); 2339 flags));
2332 } 2340 }
2333 2341
2342 void RenderFrameImpl::didChangeFrameOwnerProperties(
2343 blink::WebFrame* child_frame,
2344 const blink::WebFrameOwnerProperties& frame_owner_properties) {
2345 int frame_routing_id = GetRoutingIDForFrame(child_frame);
2346 Send(new FrameHostMsg_DidChangeFrameOwnerProperties(
2347 routing_id_, frame_routing_id, frame_owner_properties));
2348 }
2349
2334 void RenderFrameImpl::didMatchCSS( 2350 void RenderFrameImpl::didMatchCSS(
2335 blink::WebLocalFrame* frame, 2351 blink::WebLocalFrame* frame,
2336 const blink::WebVector<blink::WebString>& newly_matching_selectors, 2352 const blink::WebVector<blink::WebString>& newly_matching_selectors,
2337 const blink::WebVector<blink::WebString>& stopped_matching_selectors) { 2353 const blink::WebVector<blink::WebString>& stopped_matching_selectors) {
2338 DCHECK(!frame_ || frame_ == frame); 2354 DCHECK(!frame_ || frame_ == frame);
2339 2355
2340 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, 2356 FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
2341 DidMatchCSS(newly_matching_selectors, 2357 DidMatchCSS(newly_matching_selectors,
2342 stopped_matching_selectors)); 2358 stopped_matching_selectors));
2343 } 2359 }
(...skipping 2761 matching lines...) Expand 10 before | Expand all | Expand 10 after
5105 mojo::ServiceProviderPtr service_provider; 5121 mojo::ServiceProviderPtr service_provider;
5106 mojo::URLRequestPtr request(mojo::URLRequest::New()); 5122 mojo::URLRequestPtr request(mojo::URLRequest::New());
5107 request->url = mojo::String::From(url); 5123 request->url = mojo::String::From(url);
5108 mojo_shell_->ConnectToApplication(request.Pass(), GetProxy(&service_provider), 5124 mojo_shell_->ConnectToApplication(request.Pass(), GetProxy(&service_provider),
5109 nullptr, nullptr, 5125 nullptr, nullptr,
5110 base::Bind(&OnGotContentHandlerID)); 5126 base::Bind(&OnGotContentHandlerID));
5111 return service_provider.Pass(); 5127 return service_provider.Pass();
5112 } 5128 }
5113 5129
5114 } // namespace content 5130 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698