Make CallocDiesOnOOM return false under TSan and ASan. Their allocators return NULL in the case of …

Make CallocDiesOnOOM return false under TSan, MSan and ASan. Their allocators return NULL in the case of an overflow.

BUG=175554, 172149
TBR=mark

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190437

[Alexander Potapenko, 2013-03-25 08:54:56]

Julien, PTAL
Kostya, FYI

[jln (very slow on Chromium), 2013-03-25 15:05:48]

lgtm

https://codereview.chromium.org/13061002/diff/1/base/security_unittest.cc
File base/security_unittest.cc (right):

https://codereview.chromium.org/13061002/diff/1/base/security_unittest.cc#new...
base/security_unittest.cc:70: (!defined(ADDRESS_SANITIZER) &&
!defined(THREAD_SANITIZER))
Could you add a comment for the second part ? The existing comment only covers
the first part.

[Alexander Potapenko, 2013-03-25 15:07:51]

Done.

[jln (DO NOT USE THIS), 2013-03-25 15:22:50]

On 2013/03/25 15:07:51, Alexander Potapenko wrote:
> Done.

It looks like you added a comment at the wrong place.

[Alexander Potapenko, 2013-03-25 15:37:01]

You're right, sorry about that. Fixed, added MSan.

[commit-bot: I haz the power, 2013-03-25 15:38:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/13061002/1002

[commit-bot: I haz the power, 2013-03-25 15:38:21]

Presubmit check for 13061002-1002 failed and returned exit status 1.

INFO:root:Found 1 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    base/security_unittest.cc

[Alexander Potapenko, 2013-03-25 15:41:48]

TBRing Mark as one of the base/ owners.

[commit-bot: I haz the power, 2013-03-25 15:42:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/13061002/1002

[Mark Mentovai, 2013-03-25 15:46:54]

LGTM

[commit-bot: I haz the power, 2013-03-25 18:04:17]

Change committed as 190437