Issue 13060003: Extract Extension IME related utility.

Issue 13060003: Extract Extension IME related utility. (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka

Modified:
7 years, 9 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extract Extension IME related utility. BUG=164377, 164375 TEST=ran chromeos_unittests and unit_tests TBR=satorux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190694

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Addressing comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -43 lines)			Patch
M	chrome/browser/chromeos/input_method/ibus_controller_impl.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	1	5 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	1	9 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1	3 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chromeos/chromeos.gyp	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
A	chromeos/ime/extension_ime_util.h	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	chromeos/ime/extension_ime_util.cc	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
A	chromeos/ime/extension_ime_util_unittest.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

https://codereview.chromium.org/13060003/diff/26/chromeos/ime/extension_ime_util.cc File chromeos/ime/extension_ime_util.cc (right): https://codereview.chromium.org/13060003/diff/26/chromeos/ime/extension_ime_util.cc#newcode25 chromeos/ime/extension_ime_util.cc:25: false); // Case insensitive. Why is this case insensitive?

7 years, 9 months ago (2013-03-26 09:22:14 UTC) #2

Seigo Nonaka

7 years, 9 months ago (2013-03-26 09:27:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13060003/6001

7 years, 9 months ago (2013-03-26 13:46:49 UTC) #6

commit-bot: I haz the power

Presubmit check for 13060003-6001 failed and returned exit status 1. INFO:root:Found 12 file(s). Running presubmit ...

7 years, 9 months ago (2013-03-26 13:46:56 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13060003/6001

7 years, 9 months ago (2013-03-26 13:57:28 UTC) #9

Message was sent while issue was closed.

Change committed as 190694

Expand Messages | Collapse Messages