Issue 13058003: Convert native strip from rule to action

Issue 13058003: Convert native strip from rule to action (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@libraryloader

Visibility:
Public.

More Reviews

Description

Convert native strip from rule to action First, this allows us to correctly have the output of the copy/strip action be an input to the apk package action. Second, this step now uses the list of libraries created by ordered libraries step. This is required to support the component build where we can not manually list the required libraries. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191754

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Rebase #

Patch Set 5 : Fix package input paths #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -32 lines)			Patch
	M	build/android/strip_library_for_apk.py	View	1 2 3	2 chunks	+18 lines, -4 lines	0 comments	Download
	M	build/java_apk.gypi	View	1 2 3 4	7 chunks	+28 lines, -28 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://codereview.chromium.org/13058003/diff/2001/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/13058003/diff/2001/build/java_apk.gypi#newcode96 build/java_apk.gypi:96: '<@(native_libs_paths)', It seems like this is unneeded now. ...

7 years, 8 months ago (2013-03-29 00:17:02 UTC) #2

cjhopman

https://codereview.chromium.org/13058003/diff/2001/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/13058003/diff/2001/build/java_apk.gypi#newcode96 build/java_apk.gypi:96: '<@(native_libs_paths)', On 2013/03/29 00:17:03, Yaron wrote: > It seems ...

7 years, 8 months ago (2013-03-29 20:37:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13058003/17005

7 years, 8 months ago (2013-04-01 23:17:08 UTC) #5

Message was sent while issue was closed.

Change committed as 191754

Expand Messages | Collapse Messages