Change all other AutofillDialogView methods with a const DetailInput& as a param

chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h"
 
 #include "base/bind.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 134 matching lines @@
 
 void AutofillDialogCocoa::SubmitForTesting() {
   [sheet_delegate_ accept:nil];
 }
 
 void AutofillDialogCocoa::CancelForTesting() {
   [sheet_delegate_ cancel:nil];
 }
 
 base::string16 AutofillDialogCocoa::GetTextContentsOfInput(
-    const DetailInput& input) {
+    ServerFieldType type) {
   for (size_t i = SECTION_MIN; i <= SECTION_MAX; ++i) {

[groby-ooo-7-16, 2014/01/09 19:35:21]

We don't have a way currently to get DialogSection from ServerFieldType, do we?
Because that'd save a whole lot of iteratin' here.

[Dan Beam, 2014/01/09 19:44:22]

AutofillType(type).group() would give you a good hint.  views has a map of type
-> {combobox,textarea}.

     DialogSection section = static_cast<DialogSection>(i);
     FieldValueMap contents;
     [sheet_delegate_ getInputs:&contents forSection:section];
-    FieldValueMap::const_iterator it = contents.find(input.type);
+    FieldValueMap::const_iterator it = contents.find(type);
     if (it != contents.end())
       return it->second;
   }
 
   NOTREACHED();
   return base::string16();
 }
 
 void AutofillDialogCocoa::SetTextContentsOfInput(
-    const DetailInput& input,
+    ServerFieldType type,
     const base::string16& contents) {
   [sheet_delegate_ setTextContents:base::SysUTF16ToNSString(contents)
-                          forInput:input];
+                           forType:type];
 }
 
 void AutofillDialogCocoa::SetTextContentsOfSuggestionInput(
     DialogSection section,
     const base::string16& text) {
   [sheet_delegate_ setTextContents:base::SysUTF16ToNSString(text)
             ofSuggestionForSection:section];
 }
 
-void AutofillDialogCocoa::ActivateInput(const DetailInput& input) {
-  [sheet_delegate_ activateFieldForInput:input];
+void AutofillDialogCocoa::ActivateInput(ServerFieldType type) {
+  [sheet_delegate_ activateFieldForType:type];
 }
 
 gfx::Size AutofillDialogCocoa::GetSize() const {
   return gfx::Size(NSSizeToCGSize([[sheet_delegate_ window] frame].size));
 }
 
 content::WebContents* AutofillDialogCocoa::GetSignInWebContents() {
   return [sheet_delegate_ getSignInWebContents];
 }
 
 
 bool AutofillDialogCocoa::IsShowingOverlay() const {
   return [sheet_delegate_ isShowingOverlay];
 }
 
 void AutofillDialogCocoa::OnConstrainedWindowClosed(
     ConstrainedWindowMac* window) {
   constrained_window_.reset();
   // |this| belongs to |delegate_|, so no self-destruction here.
   delegate_->ViewClosed();
 }
 
 }  // autofill