Issue 13047011: SyncFS: Do not dereference scoped_ptr<Param> after we pass in StartOverRemoteSync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13047011: SyncFS: Do not dereference scoped_ptr<Param> after we pass in StartOverRemoteSync (Closed)

Created:
7 years, 9 months ago by kinuko

Modified:
7 years, 9 months ago

Reviewers:
calvinlo, nhiroki, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

SyncFS: Do not dereference scoped_ptr<Param> after we pass in StartOverRemoteSync We're keeping a token and going to call a method which takes token, so we should probably just call the method there. BUG=223705 TEST=manual NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190509

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/sync_file_system/drive_file_sync_service.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/13047011/1

7 years, 9 months ago (2013-03-25 22:43:12 UTC) #3

Message was sent while issue was closed.

Change committed as 190509

Expand Messages | Collapse Messages