Issue 13044007: Fix the Android.mk gyp backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13044007: Fix the Android.mk gyp backend. (Closed)

Created:
7 years, 9 months ago by mkosiba (inactive)

Modified:
7 years, 9 months ago

Reviewers:
Torne

CC:
chromium-reviews, cjhopman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the Android.mk gyp backend. Add missing quotes to the expansion in java.gypi such that the shell doesn't try to expand make variables. BUG=None TEST=run android_webview/tools/gyp_webview NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190917

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/java_apk.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/13044007/1

7 years, 9 months ago (2013-03-27 11:55:18 UTC) #3

Message was sent while issue was closed.

Change committed as 190917

Expand Messages | Collapse Messages