Cast:Updating logging stats

media/cast/logging/logging_impl.h

Index: media/cast/logging/logging_impl.h
diff --git a/media/cast/logging/logging_impl.h b/media/cast/logging/logging_impl.h
index bf518699c230dd37ae722c0c8a16fcd8fa2431a4..27f177c5eb9a93bb4beab68e0010341d9e32a53b 100644
--- a/media/cast/logging/logging_impl.h
+++ b/media/cast/logging/logging_impl.h
@@ -62,18 +62,20 @@ class LoggingImpl : public base::NonThreadSafe {
                           int value);
 
   // Get raw data.
-  FrameRawMap GetFrameRawData();
-  PacketRawMap GetPacketRawData();
-  GenericRawMap GetGenericRawData();
-  AudioRtcpRawMap GetAudioRtcpRawData();
-  VideoRtcpRawMap GetVideoRtcpRawData();
-
-  // Get stats only (computed when called). Triggers UMA stats when enabled.
-  const FrameStatsMap* GetFrameStatsData(const base::TimeTicks& now);
-  const PacketStatsMap* GetPacketStatsData(const base::TimeTicks& now);
-  const GenericStatsMap* GetGenericStatsData();
-
-  // Reset raw logging data.
+  FrameRawMap GetFrameRawData() const;
+  PacketRawMap GetPacketRawData() const;
+  GenericRawMap GetGenericRawData() const;
+
+  // Get the RTCP data and reset the data.
+  AudioRtcpRawMap GetAndResetAudioRtcpRawData();
+  VideoRtcpRawMap GetAndResetVideoRtcpRawData();

[hguihot1, 2014/01/23 23:42:50]

I don't quite get why these are GetAndReset() (when other ones have 2 API, Get()
and Reset()). Any specific reason?

[mikhal1, 2014/01/29 19:25:49]

I would rather them both have a GetAndReset, but you (as the customer) preferred
not to have it that way, and the RTCP implementation preferred it this way.
Regardless, it will become obsolete with latest refactoring efforts. 
On 2014/01/23 23:42:50, hguihot1 wrote:

+
+  // Get stats only.
+  FrameStatsMap GetFrameStatsData() const;
+  PacketStatsMap GetPacketStatsData() const;
+  GenericStatsMap GetGenericStatsData() const;
+
+  // Reset raw logging data (this does not reset the RTCP raw data).
   void ResetRaw();
   // Reset stats logging data.
   void ResetStats();