Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: media/cast/logging/logging_stats.h

Issue 130423007: Cast:Updating logging stats (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/logging/logging_stats.h
diff --git a/media/cast/logging/logging_stats.h b/media/cast/logging/logging_stats.h
index 4421ecd370474e31d8c6e554353eef5f9c297b5a..7854816ec609fec184b71bd7164c45e7882309d8 100644
--- a/media/cast/logging/logging_stats.h
+++ b/media/cast/logging/logging_stats.h
@@ -47,13 +47,11 @@ class LoggingStats {
void InsertGenericEvent(const base::TimeTicks& time_of_event,
CastLoggingEvent event, int value);
- // Get log stats: some of the values, such as frame rate and bit rates are
- // computed at the time of the call.
- const FrameStatsMap* GetFrameStatsData(const base::TimeTicks& now);
+ const FrameStatsMap* GetFrameStatsData() const;
imcheng 2014/01/22 21:03:37 Can you provide some documentation? (e.g. ownershi
mikhal1 2014/01/23 19:53:11 Done.
- const PacketStatsMap* GetPacketStatsData(const base::TimeTicks& now);
+ const PacketStatsMap* GetPacketStatsData() const;
- const GenericStatsMap* GetGenericStatsData();
+ const GenericStatsMap* GetGenericStatsData() const;
private:
void InsertBaseFrameEvent(const base::TimeTicks& time_of_event,
@@ -64,10 +62,6 @@ class LoggingStats {
FrameStatsMap frame_stats_;
PacketStatsMap packet_stats_;
GenericStatsMap generic_stats_;
- // Every event has an individual start time
- base::TimeTicks start_time_[kNumOfLoggingEvents];
- // Keep track of event counts.
- int counts_[kNumOfLoggingEvents];
DISALLOW_COPY_AND_ASSIGN(LoggingStats);
};

Powered by Google App Engine
This is Rietveld 408576698