Cast:Updating logging stats

media/cast/logging/logging_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event.h"
 #include "base/metrics/histogram.h"
 #include "media/cast/logging/logging_impl.h"
 #include "net/base/big_endian.h"
 
 namespace media {
@@ skipping 36 matching lines @@
   if (config_.enable_raw_data_collection) {
     raw_.InsertFrameEventWithSize(time_of_event, event, rtp_timestamp, frame_id,
                                   frame_size);
   }
   if (config_.enable_stats_data_collection) {
     stats_.InsertFrameEventWithSize(time_of_event, event, rtp_timestamp,
                                     frame_id, frame_size);
   }
   if (config_.enable_uma_stats) {
     if (event == kAudioFrameEncoded)
       UMA_HISTOGRAM_COUNTS("Cast.AudioFrameEncoded", frame_size);

[hguihot1, 2014/01/22 21:41:13]

AudioFrameEncodedSize?

[mikhal1, 2014/01/23 19:53:11]

Done.

     else if (event == kVideoFrameEncoded) {
       UMA_HISTOGRAM_COUNTS("Cast.VideoFrameEncoded", frame_size);

[hguihot1, 2014/01/22 21:41:13]

VideoFrameEncodedSize?

[mikhal1, 2014/01/23 19:53:11]

Done.

     }
   }
 
   if (config_.enable_tracing) {
     std::string event_string = CastLoggingToString(event);
     TRACE_EVENT_INSTANT2(event_string.c_str(), "FES",
         TRACE_EVENT_SCOPE_THREAD, "rtp_timestamp", rtp_timestamp, "frame_size",
         frame_size);
   }
 }
@@ skipping 91 matching lines @@
         TRACE_EVENT_SCOPE_THREAD, "value", value);
   }
 }
 
 void LoggingImpl::InsertGenericUmaEvent(CastLoggingEvent event, int value) {
   switch(event) {
     case kRttMs:
       UMA_HISTOGRAM_COUNTS("Cast.RttMs", value);
       break;
     case kPacketLoss:
       UMA_HISTOGRAM_COUNTS("Cast.PacketLoss", value);

[hguihot1, 2014/01/22 21:41:13]

Maybe a better name than PacketLoss? It does not say what this is (percentage,
absolute value, etc)

[mikhal1, 2014/01/23 19:53:11]

Done.

       break;
     case kJitterMs:
       UMA_HISTOGRAM_COUNTS("Cast.JitterMs", value);
       break;
     case kRembBitrate:
       UMA_HISTOGRAM_COUNTS("Cast.RembBitrate", value);
       break;
     default:
       // No-op
       break;
   }
 }
 
 // should just get the entire class, would be much easier.
-FrameRawMap LoggingImpl::GetFrameRawData() {
+FrameRawMap LoggingImpl::GetFrameRawData() const {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   return raw_.GetFrameData();
 }
 
-PacketRawMap LoggingImpl::GetPacketRawData() {
+PacketRawMap LoggingImpl::GetPacketRawData() const {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   return raw_.GetPacketData();
 }
 
-GenericRawMap LoggingImpl::GetGenericRawData() {
+GenericRawMap LoggingImpl::GetGenericRawData() const {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   return raw_.GetGenericData();
 }
 
 AudioRtcpRawMap LoggingImpl::GetAudioRtcpRawData() {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   return raw_.GetAndResetAudioRtcpData();
 }
 
 VideoRtcpRawMap LoggingImpl::GetVideoRtcpRawData() {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   return raw_.GetAndResetVideoRtcpData();
 }
 
-const FrameStatsMap* LoggingImpl::GetFrameStatsData(
-    const base::TimeTicks& now) {
+const FrameStatsMap* LoggingImpl::GetFrameStatsData() const {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
-  // Get stats data.
-  const FrameStatsMap* stats = stats_.GetFrameStatsData(now);
-  if (config_.enable_uma_stats) {
-    FrameStatsMap::const_iterator it;
-    for (it = stats->begin(); it != stats->end(); ++it) {
-      // Check for an active event.
-      // The default frame event implies frame rate.
-      if (it->second->framerate_fps > 0) {
-        switch (it->first) {
-          case kAudioFrameReceived:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioFrameReceived",
-                it->second->framerate_fps);
-            break;
-          case kAudioFrameCaptured:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioFrameCaptured",
-                it->second->framerate_fps);
-            break;
-          case kAudioFrameEncoded:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioFrameEncoded",
-                it->second->framerate_fps);
-            break;
-          case kVideoFrameCaptured:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoFrameCaptured",
-                it->second->framerate_fps);
-            break;
-          case kVideoFrameReceived:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoFrameReceived",
-                it->second->framerate_fps);
-            break;
-          case kVideoFrameSentToEncoder:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoFrameSentToEncoder",
-                it->second->framerate_fps);
-            break;
-          case kVideoFrameEncoded:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoFrameEncoded",
-                it->second->framerate_fps);
-            break;
-          case kVideoFrameDecoded:
-            UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoFrameDecoded",
-                it->second->framerate_fps);
-            break;
-          default:
-            // No-op
-            break;
-        }
-      } else {
-        // All active frame events trigger frame rate computation.
-        continue;
-      }
-      // Bit rate should only be provided following encoding for either audio
-      // or video.
-      if (it->first == kVideoFrameEncoded) {
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoBitrateKbps",
-            it->second->framerate_fps);
-      } else if (it->first == kAudioFrameEncoded) {
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioBitrateKbps",
-            it->second->framerate_fps);
-      }
-      // Delay events.
-      if (it->first == kAudioPlayoutDelay) {
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioPlayoutDelayAvg",
-            it->second->avg_delay_ms);
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioPlayoutDelayMin",
-            it->second->min_delay_ms);
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.AudioPlayoutDelayMax",
-            it->second->max_delay_ms);
-      } else if (it->first == kVideoRenderDelay) {
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoPlayoutDelayAvg",
-            it->second->avg_delay_ms);
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoPlayoutDelayMin",
-            it->second->min_delay_ms);
-        UMA_HISTOGRAM_COUNTS("Cast.Stats.VideoPlayoutDelayMax",
-            it->second->max_delay_ms);
-      }
-    }
-  }
-  return stats;
+  return stats_.GetFrameStatsData();
 }
 
-const PacketStatsMap* LoggingImpl::GetPacketStatsData(
-    const base::TimeTicks& now) {
+const PacketStatsMap* LoggingImpl::GetPacketStatsData() const {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
-  // Get stats data.
-  const PacketStatsMap* stats = stats_.GetPacketStatsData(now);
-  if (config_.enable_uma_stats) {
-    PacketStatsMap::const_iterator it;
-    for (it = stats->begin(); it != stats->end(); ++it) {
-      switch (it->first) {
-        case kPacketSentToPacer:
-          UMA_HISTOGRAM_COUNTS("Cast.Stats.PacketSentToPacer", it->second);
-          break;
-        case kPacketSentToNetwork:
-          UMA_HISTOGRAM_COUNTS("Cast.Stats.PacketSentToNetwork", it->second);
-          break;
-        case kPacketRetransmitted:
-          UMA_HISTOGRAM_COUNTS("Cast.Stats.PacketRetransmited", it->second);
-          break;
-        case kDuplicatePacketReceived:
-          UMA_HISTOGRAM_COUNTS("Cast.Stats.DuplicatePacketReceived",
-                               it->second);
-          break;
-        default:
-          // No-op.
-          break;
-      }
-    }
-  }
-  return stats;
+  return stats_.GetPacketStatsData();
 }
 
-const GenericStatsMap* LoggingImpl::GetGenericStatsData() {
+const GenericStatsMap* LoggingImpl::GetGenericStatsData() const {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
-  // Get stats data.
-  const GenericStatsMap* stats = stats_.GetGenericStatsData();
-  return stats;
+  return stats_.GetGenericStatsData();
 }
 
 void LoggingImpl::ResetRaw() {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   raw_.Reset();
 }
 
 void LoggingImpl::ResetStats() {
   DCHECK(main_thread_proxy_->RunsTasksOnCurrentThread());
   stats_.Reset();
 }
 
 }  // namespace cast
 }  // namespace media