Issue 13042007: Extract input_method_whitelist.{h|cc} from c/b/chromeos. (2nd try)

Issue 13042007: Extract input_method_whitelist.{h|cc} from c/b/chromeos. (2nd try) (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka

Modified:
7 years, 9 months ago

Reviewers:
satorux1

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Extract input_method_whitelist.{h|cc} from c/b/chromeos. This is the 2nd try of https://codereview.chromium.org/12438012/ It turned out that c/b/chromeos/input_methods/input_methods.txt is also used by chromeos side. So keeping c/b/chromeos/input_methods/input_methods.txt as is for migration and after change is in chromeos tree, I will remove it. BUG=164375 TEST=None TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191325

Patch Set 1 : base #

Patch Set 2 : replicate input_methods.txt for migration #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -306 lines)			Patch
D	chrome/browser/chromeos/input_method/gen_input_methods.py	View		1 chunk	+0 lines, -123 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/chromeos/input_method/input_method.gyp	View		1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/chromeos/input_method/input_method_whitelist.h	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/chromeos/input_method/input_method_whitelist.cc	View		1 chunk	+0 lines, -45 lines	0 comments	Download
D	chrome/browser/chromeos/input_method/input_method_whitelist_unittest.cc	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_methods.txt	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/chromeos.gyp	View		3 chunks	+4 lines, -0 lines	0 comments	Download
A +	chromeos/ime/gen_input_methods.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chromeos/ime/input_method.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chromeos/ime/input_method_whitelist.h	View		4 chunks	+8 lines, -6 lines	0 comments	Download
A +	chromeos/ime/input_method_whitelist.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	chromeos/ime/input_method_whitelist_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chromeos/ime/input_methods.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

I'm sorry for build break on cros bot. I found the fix about it. Please ...

7 years, 9 months ago (2013-03-27 11:26:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13042007/2002

7 years, 9 months ago (2013-03-29 04:53:44 UTC) #4

Message was sent while issue was closed.

Change committed as 191325

Expand Messages | Collapse Messages