Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 13037002: Undo b222509 HEAPCHECK suppression. (Closed)

Created:
7 years, 9 months ago by yhirano
Modified:
7 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Undo b222509 HEAPCHECK suppression. The leak seems to not reproduce. BUG=222509 TBR=thestig NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 9 months ago (2013-03-25 20:44:22 UTC) #1
yhirano
TBR
7 years, 9 months ago (2013-03-25 20:45:51 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-25 20:47:43 UTC) #3
Lei Zhang
lgtm, the leak seems to have gone away on its own. :-\
7 years, 9 months ago (2013-03-25 20:47:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/13037002/1
7 years, 9 months ago (2013-03-25 20:51:44 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 20:54:57 UTC) #6
Message was sent while issue was closed.
Change committed as 190477

Powered by Google App Engine
This is Rietveld 408576698