Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: impl/memory/gkvlite_utils.go

Issue 1302813003: impl/memory: Implement Queries (Closed) Base URL: https://github.com/luci/gae.git@add_multi_iterator
Patch Set: Baby's first query! Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: impl/memory/gkvlite_utils.go
diff --git a/impl/memory/gkvlite_utils.go b/impl/memory/gkvlite_utils.go
index ac64f9b7d7905f1233459120d4231e7e3671b309..88c01018cac80f018b22a70493cce4787c5de286 100644
--- a/impl/memory/gkvlite_utils.go
+++ b/impl/memory/gkvlite_utils.go
@@ -69,9 +69,7 @@ type memStore gkvlite.Store
func newMemStore() *memStore {
ret, err := gkvlite.NewStore(nil)
- if err != nil {
- panic(err)
- }
+ memoryCorruption(err)
return (*memStore)(ret)
}
@@ -105,44 +103,34 @@ type memCollection gkvlite.Collection
func (mc *memCollection) Get(k []byte) []byte {
ret, err := (*gkvlite.Collection)(mc).Get(k)
- if err != nil {
- panic(err)
- }
+ memoryCorruption(err)
return ret
}
func (mc *memCollection) MinItem(withValue bool) *gkvlite.Item {
ret, err := (*gkvlite.Collection)(mc).MinItem(withValue)
- if err != nil {
- panic(err)
- }
+ memoryCorruption(err)
return ret
}
func (mc *memCollection) Set(k, v []byte) {
- if err := (*gkvlite.Collection)(mc).Set(k, v); err != nil {
- panic(err)
- }
+ err := (*gkvlite.Collection)(mc).Set(k, v)
+ memoryCorruption(err)
}
func (mc *memCollection) Delete(k []byte) bool {
ret, err := (*gkvlite.Collection)(mc).Delete(k)
- if err != nil {
- panic(err)
- }
+ memoryCorruption(err)
return ret
}
func (mc *memCollection) VisitItemsAscend(target []byte, withValue bool, visitor gkvlite.ItemVisitor) {
- if err := (*gkvlite.Collection)(mc).VisitItemsAscend(target, withValue, visitor); err != nil {
- panic(err)
- }
+ err := (*gkvlite.Collection)(mc).VisitItemsAscend(target, withValue, visitor)
+ memoryCorruption(err)
}
func (mc *memCollection) GetTotals() (numItems, numBytes uint64) {
numItems, numBytes, err := (*gkvlite.Collection)(mc).GetTotals()
- if err != nil {
- panic(err)
- }
+ memoryCorruption(err)
return
}

Powered by Google App Engine
This is Rietveld 408576698