Allow overriding Chromium-branded Android resources.
The chrome_java target includes several resources that are specific to a
Chromium-branded build (e.g. the Chromium icon and app name). It's now
possible to set a value for the GYP/GN variable
android_branding_res_dirs to override the directory in which these
branding resources live. This enables easy swapping of the resources
when building, e.g., a Google Chrome-branded build.
R=yfriedman@chromium.orgTBR=thestig@chromium.org
BUG=520794, 474747
Committed: https://chromium.googlesource.com/chromium/src/+/60e61e8a7f98c447baadb317ad56d49c755e0071
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301613002/1
5 years, 4 months ago
(2015-08-17 17:27:41 UTC)
#7
On 2015/08/17 17:27:47, agrieve wrote: > On 2015/08/17 17:05:03, Yaron (OOO 8.18-8.21) wrote: > > ...
5 years, 4 months ago
(2015-08-17 17:29:43 UTC)
#11
On 2015/08/17 17:27:47, agrieve wrote:
> On 2015/08/17 17:05:03, Yaron (OOO 8.18-8.21) wrote:
> > lgtm
>
> (added BUG=474747, as I think this fixes that as well!)
Indeed. Thanks!
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301613002/1
5 years, 4 months ago
(2015-08-17 17:29:47 UTC)
#12
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88920)
5 years, 4 months ago
(2015-08-17 17:38:09 UTC)
#14
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301613002/1
5 years, 4 months ago
(2015-08-17 17:40:58 UTC)
#16
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99084)
5 years, 4 months ago
(2015-08-17 20:30:49 UTC)
#18
Issue 1301613002: Allow overriding Chromium-branded Android resources.
(Closed)
Created 5 years, 4 months ago by newt (away)
Modified 5 years, 4 months ago
Reviewers: Yaron, Lei Zhang
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0