Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1301613002: Allow overriding Chromium-branded Android resources. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow overriding Chromium-branded Android resources. The chrome_java target includes several resources that are specific to a Chromium-branded build (e.g. the Chromium icon and app name). It's now possible to set a value for the GYP/GN variable android_branding_res_dirs to override the directory in which these branding resources live. This enables easy swapping of the resources when building, e.g., a Google Chrome-branded build. R=yfriedman@chromium.org TBR=thestig@chromium.org BUG=520794, 474747 Committed: https://chromium.googlesource.com/chromium/src/+/60e61e8a7f98c447baadb317ad56d49c755e0071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/android/java/res/drawable-hdpi/fre_product_logo.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/product_logo_name.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/fre_product_logo.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/product_logo_name.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/fre_product_logo.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/product_logo_name.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/fre_product_logo.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/product_logo_name.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/fre_product_logo.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/product_logo_name.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-hdpi/fre_product_logo.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-hdpi/product_logo_name.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-mdpi/fre_product_logo.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-mdpi/product_logo_name.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-xhdpi/fre_product_logo.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-xhdpi/product_logo_name.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-xxhdpi/fre_product_logo.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-xxhdpi/product_logo_name.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-xxxhdpi/fre_product_logo.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/drawable-xxxhdpi/product_logo_name.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-hdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-hdpi/app_shortcut_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-mdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-mdpi/app_shortcut_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-xhdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-xhdpi/app_shortcut_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-xxhdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-xxhdpi/app_shortcut_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-xxxhdpi/app_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/mipmap-xxxhdpi/app_shortcut_icon.png View Binary file 0 comments Download
A + chrome/android/java/res_chromium/values/channel_constants.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/java/res_default/mipmap-hdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-hdpi/app_shortcut_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-mdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-mdpi/app_shortcut_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-xhdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-xhdpi/app_shortcut_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-xxhdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-xxhdpi/app_shortcut_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-xxxhdpi/app_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/mipmap-xxxhdpi/app_shortcut_icon.png View Binary file 0 comments Download
D chrome/android/java/res_default/values/channel_constants.xml View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
newt (away)
PTAL
5 years, 4 months ago (2015-08-17 16:22:23 UTC) #2
Yaron
lgtm
5 years, 4 months ago (2015-08-17 17:05:03 UTC) #3
newt (away)
TBR thestig for Android-only change to chrome.gyp
5 years, 4 months ago (2015-08-17 17:27:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301613002/1
5 years, 4 months ago (2015-08-17 17:27:41 UTC) #7
agrieve
On 2015/08/17 17:05:03, Yaron (OOO 8.18-8.21) wrote: > lgtm (added BUG=474747, as I think this ...
5 years, 4 months ago (2015-08-17 17:27:47 UTC) #8
newt (away)
On 2015/08/17 17:27:47, agrieve wrote: > On 2015/08/17 17:05:03, Yaron (OOO 8.18-8.21) wrote: > > ...
5 years, 4 months ago (2015-08-17 17:29:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301613002/1
5 years, 4 months ago (2015-08-17 17:29:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88920)
5 years, 4 months ago (2015-08-17 17:38:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301613002/1
5 years, 4 months ago (2015-08-17 17:40:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99084)
5 years, 4 months ago (2015-08-17 20:30:49 UTC) #18
newt (away)
Committed patchset #1 (id:1) manually as 60e61e8a7f98c447baadb317ad56d49c755e0071 (presubmit successful).
5 years, 4 months ago (2015-08-17 20:43:51 UTC) #19
Lei Zhang
5 years, 4 months ago (2015-08-17 21:19:28 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698