Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 13006014: remove redundant DCHECK that a size_t variable >= 0 (Closed)

Created:
7 years, 9 months ago by Mostyn Bramley-Moore
Modified:
7 years, 9 months ago
CC:
chromium-reviews, MAD, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

remove redundant DCHECK that a size_t variable >= 0 SampleVector::GetCountAtIndex has a DCHECK which checks that a size_t variable is >= 0 and then some other condition. But size_t is an unsigned type so the first part of the check is useless (and it gives an error because of this with clang). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/metrics/sample_vector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Mostyn Bramley-Moore
This was originally uploaded and reviewed here (uploaded again with a different account since I ...
7 years, 9 months ago (2013-03-25 21:29:37 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-26 03:41:21 UTC) #2
Ilya Sherman
lgtm
7 years, 9 months ago (2013-03-26 04:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/13006014/1
7 years, 9 months ago (2013-03-26 04:39:08 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=111319
7 years, 9 months ago (2013-03-26 05:46:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/13006014/1
7 years, 9 months ago (2013-03-26 05:59:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/13006014/1
7 years, 9 months ago (2013-03-26 07:10:55 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=111354
7 years, 9 months ago (2013-03-26 09:37:19 UTC) #8
Mostyn Bramley-Moore
On 2013/03/26 09:37:19, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 9 months ago (2013-03-26 10:09:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/13006014/1
7 years, 9 months ago (2013-03-26 10:20:11 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=111370
7 years, 9 months ago (2013-03-26 12:40:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/13006014/1
7 years, 9 months ago (2013-03-26 21:01:51 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 22:02:03 UTC) #13
Message was sent while issue was closed.
Change committed as 190776

Powered by Google App Engine
This is Rietveld 408576698