Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 12996002: cc: Chromify TilingData unittest (Closed)

Created:
7 years, 9 months ago by enne (OOO)
Modified:
7 years, 9 months ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, jamesr
Visibility:
Public.

Description

cc: Chromify TilingData unittest NOTRY=true R=danakj@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189832

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -56 lines) Patch
M cc/base/tiling_data_unittest.cc View 1 28 chunks +28 lines, -56 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
7 years, 9 months ago (2013-03-21 17:58:04 UTC) #1
jamesr
lgtm (sniped!)
7 years, 9 months ago (2013-03-21 17:58:50 UTC) #2
danakj
https://codereview.chromium.org/12996002/diff/1/cc/base/tiling_data_unittest.cc File cc/base/tiling_data_unittest.cc (right): https://codereview.chromium.org/12996002/diff/1/cc/base/tiling_data_unittest.cc#newcode791 cc/base/tiling_data_unittest.cc:791: } { >_> I should fix this.
7 years, 9 months ago (2013-03-21 17:59:22 UTC) #3
danakj
LGTM
7 years, 9 months ago (2013-03-21 17:59:25 UTC) #4
danakj
On 2013/03/21 17:58:50, jamesr wrote: > lgtm > > (sniped!) O_O
7 years, 9 months ago (2013-03-21 17:59:34 UTC) #5
enne (OOO)
https://codereview.chromium.org/12996002/diff/1/cc/base/tiling_data_unittest.cc File cc/base/tiling_data_unittest.cc (right): https://codereview.chromium.org/12996002/diff/1/cc/base/tiling_data_unittest.cc#newcode791 cc/base/tiling_data_unittest.cc:791: } { On 2013/03/21 17:59:22, danakj wrote: > >_> ...
7 years, 9 months ago (2013-03-21 18:02:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12996002/7001
7 years, 9 months ago (2013-03-21 18:14:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12996002/7001
7 years, 9 months ago (2013-03-22 16:30:50 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-22 16:31:11 UTC) #9
Message was sent while issue was closed.
Change committed as 189832

Powered by Google App Engine
This is Rietveld 408576698