Issue 12989004: Clean up GrCircleEdgeEffect and GrEllipseEdgeEffect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12989004: Clean up GrCircleEdgeEffect and GrEllipseEdgeEffect (Closed)

Created:
7 years, 9 months ago by jvanverth1

Modified:
7 years, 9 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Clean up GrCircleEdgeEffect and GrEllipseEdgeEffect. Remove unnecessary headers and fix onIsEqual() for both classes. Committed: http://code.google.com/p/skia/source/detail?r=8327

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -11 lines)			Patch
M	src/gpu/effects/GrCircleEdgeEffect.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrCircleEdgeEffect.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/gpu/effects/GrEllipseEdgeEffect.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrEllipseEdgeEffect.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/12989004/1

7 years, 9 months ago (2013-03-22 12:21:53 UTC) #3

Message was sent while issue was closed.

Change committed as 8327