Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: content/content_tests.gypi

Issue 12988003: [Android] Fix remaining linker errors for components build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/content_constants_internal.h ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_tests.gypi
diff --git a/content/content_tests.gypi b/content/content_tests.gypi
index b3d78000a77841eb477c238173514e5bbf8524ee..e4a66b05f299a34bcf8c4a2153e7986018bb7d59 100644
--- a/content/content_tests.gypi
+++ b/content/content_tests.gypi
@@ -640,6 +640,9 @@
],
}],
['OS == "android"', {
+ 'dependencies': [
+ '../ui/ui.gyp:shell_dialogs',
+ ],
'sources!': [
'browser/geolocation/device_data_provider_unittest.cc',
'browser/geolocation/gps_location_provider_unittest_linux.cc',
@@ -758,8 +761,6 @@
'browser/web_contents/web_contents_view_aura_browsertest.cc',
'browser/webkit_browsertest.cc',
'browser/worker_host/test/worker_browsertest.cc',
- 'common/content_constants_internal.cc',
- 'common/content_constants_internal.h',
'renderer/accessibility/renderer_accessibility_browsertest.cc',
'renderer/browser_plugin/mock_browser_plugin.h',
'renderer/browser_plugin/mock_browser_plugin.cc',
@@ -849,11 +850,6 @@
['OS=="android"', {
'sources!': [
'browser/accessibility/dump_accessibility_tree_browsertest.cc',
- # These are included via dependency on content_common and hence
- # we get multiple definition errors in a shared library build.
- # Other builds need it as the symbols are not exported.
- 'common/content_constants_internal.cc',
- 'common/content_constants_internal.h',
],
'sources': [
'shell/android/browsertests_apk/content_browser_tests_android.cc',
« no previous file with comments | « content/common/content_constants_internal.h ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698