[Android] Fix remaining linker errors for components build

[Android] Fix remaining linker errors for components build

Miscellaneous missing dependencies and a few more exports.

BUG=158821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191944

[Yaron, 2013-03-22 00:47:51]

Hopefully the last of these larger changes. We're in the process of getting a
bot up and this covers nearly all targets

[Ben Goodger (Google), 2013-03-22 16:17:35]

-me
+jam

[jam, 2013-03-25 21:57:34]

On 2013/03/22 16:17:35, Ben Goodger (Google) wrote:
> -me
> +jam

content lgtm

[Yaron, 2013-03-27 18:56:36]

joth: aw
gman: gpu, ui/gl
rsleevi: net
zea: sync
webkit: tony

[joth, 2013-03-27 18:58:57]

aw/ lgtm

[Ryan Sleevi, 2013-03-27 19:06:20]

https://codereview.chromium.org/12988003/diff/4001/net/url_request/url_reques...
File net/url_request/url_request_job_manager.h (right):

https://codereview.chromium.org/12988003/diff/4001/net/url_request/url_reques...
net/url_request/url_request_job_manager.h:32: class NET_EXPORT
URLRequestJobManager {
Where is this being used?

I'm a little nervous about arbitrarily NET_EXPORTing this, in that it implies an
API for others to use (particularly within Chrome @ large)

[Yaron, 2013-03-27 19:10:16]

https://codereview.chromium.org/12988003/diff/4001/net/url_request/url_reques...
File net/url_request/url_request_job_manager.h (right):

https://codereview.chromium.org/12988003/diff/4001/net/url_request/url_reques...
net/url_request/url_request_job_manager.h:32: class NET_EXPORT
URLRequestJobManager {
On 2013/03/27 19:06:21, Ryan Sleevi wrote:
> Where is this being used?
> 
> I'm a little nervous about arbitrarily NET_EXPORTing this, in that it implies
an
> API for others to use (particularly within Chrome @ large)

To be honest I didn't investigate too closely. Looks like it's from Android
Webview: android_webview/browser/net/aw_url_request_job_factory.cc

[Ryan Sleevi, 2013-03-27 19:16:44]

I'm tossing that bit to pauljensen@ then, who has been working on cleaning up
and removing bits of URLRequestJobFactory (AIUI). He's best able to comment on
whether this is a good idea, as well as likely to figure out if the
aw_url_request_job_factory code needs to be shifting APIs longer-term.

I suspect if we are going to NET_EXPORT it, it's going to be "with
caveats/comments" to indicate "don't use" - at least if I've understood the
direction the API is going.

[Nicolas Zea, 2013-03-27 19:34:50]

sync lgtm

[pauljensen, 2013-03-27 19:50:18]

We're in the process of eliminating URLRequestJobManager, though I'm guessing
that goal is months away.  There is a single call to URLRequestJobManager from
andoird_webview/ and nearby there is also a note about a dependency on
URLRequestJobManager.  This single call could be replaced with a call to
URLRequest::IsHandledProtocol() (which is NET_EXPORTed) but I think that'd just
be a band-aid.  If we're going to NET_EXPORT URLRequestJobManager I think we
should add a comment like so:
NOTE(pauljensen): The URLRequestJobManager is deprecated, do not add new calls
to it. A ProtocolInterceptJobFactory should be used in place of any of the
"Interception" functions. A URLRequestJobFactory::ProtocolHandler should be used
in place of any of the "Factory" functions.

[tony, 2013-03-27 19:57:36]

webkit LGTM

[Yaron, 2013-03-27 20:19:26]

On 2013/03/27 19:57:36, tony wrote:
> webkit LGTM

changed to URLRequest::IsHandledProtocol which does look to be equivalent. Was
able to remove the export as a result. ptal

[joth, 2013-03-27 20:33:18]

https://codereview.chromium.org/12988003/diff/13001/android_webview/browser/n...
File android_webview/browser/net/aw_url_request_job_factory.cc (right):

https://codereview.chromium.org/12988003/diff/13001/android_webview/browser/n...
android_webview/browser/net/aw_url_request_job_factory.cc:27: // This introduces
a dependency on the URLRequestJobManager
Making the change you have below means this comment is even harder to follow, as
there is no direct code dependency any more

https://codereview.chromium.org/12988003/diff/13001/android_webview/browser/n...
android_webview/browser/net/aw_url_request_job_factory.cc:51: // In that case
the built in handlers will then be used to create the job.
this comment add "see the ASSUMPTION in IsHandledProtocol above"

[Yaron, 2013-03-27 21:18:53]

https://codereview.chromium.org/12988003/diff/13001/android_webview/browser/n...
File android_webview/browser/net/aw_url_request_job_factory.cc (right):

https://codereview.chromium.org/12988003/diff/13001/android_webview/browser/n...
android_webview/browser/net/aw_url_request_job_factory.cc:27: // This introduces
a dependency on the URLRequestJobManager
On 2013/03/27 20:33:19, joth wrote:
> Making the change you have below means this comment is even harder to follow,
as
> there is no direct code dependency any more

Indeed.

https://codereview.chromium.org/12988003/diff/13001/android_webview/browser/n...
android_webview/browser/net/aw_url_request_job_factory.cc:51: // In that case
the built in handlers will then be used to create the job.
On 2013/03/27 20:33:19, joth wrote:
> this comment add "see the ASSUMPTION in IsHandledProtocol above"

Done.

[Yaron, 2013-03-29 16:35:10]

rsleevi/pauljensen: still need a net stamp
apatrick: ui/gl, gpu   (looks like gman is out)

[Yaron, 2013-03-29 16:35:21]

rsleevi/pauljensen: still need a net stamp
apatrick: ui/gl, gpu   (looks like gman is out)

[pauljensen, 2013-03-29 17:03:35]

Ryan should review.  I'm not in OWNERS.  The change that Ryan wanted me to look
over is no longer part of this CL.

[greggman, 2013-03-29 17:26:14]

lgtm

[Ryan Sleevi, 2013-03-29 17:40:38]

lgtm

[commit-bot: I haz the power, 2013-04-01 21:37:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12988003/9007

[Yaron, 2013-04-01 23:04:55]

nilesh/jam: ptal at diff from last patchset. I changed it so that
content_constants_internal isn't reincluded for any ports in
content_browsertests and instead symbols are exported. Aim is to fix win tryjob
(http://build.chromium.org/p/tryserver.chromium/builders/win/builds/60979/step...)
and unify Android with other ports.

[nilesh, 2013-04-01 23:36:00]

LGTM

[jam, 2013-04-02 17:04:22]

lgtm

[commit-bot: I haz the power, 2013-04-02 17:05:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12988003/39001

[commit-bot: I haz the power, 2013-04-02 18:27:52]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-02 19:55:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12988003/50002

[commit-bot: I haz the power, 2013-04-03 00:20:02]

Change committed as 191944