Rip autofill code out of webdataservice

Rip autofill code out of webdataservice

As it is now handled by AutofillWebDataService, and switch the last 2 clients (WebDataServiceAutofillTests and BrowsingDataRemover) over to using AutofillWebDataService.

TBR=mkwst@chromium.org,joi@chromium.org
(mkwst@ for browsing_data/ change, joi@ for api/)

BUG=181277
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190757

[Cait (Slow), 2013-03-25 21:30:45]

Hi David,

PTAL. This change removes the (now unused) autofill-related methods from the
WebDataService interface.

Thanks,
Cait

[dhollowa, 2013-03-25 21:50:38]

https://codereview.chromium.org/12987023/diff/1/chrome/browser/api/webdata/au...
File chrome/browser/api/webdata/autofill_web_data.h (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/api/webdata/au...
chrome/browser/api/webdata/autofill_web_data.h:83: // Removes form elements
recorded for Autocomplete from the database.
Please move this up near top to group with the other Autocomplete methods.

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
File chrome/browser/webdata/autofill_web_data_service_impl.cc (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.cc:164:
&AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl,
Gosh, this is excessive.  How would you feel about a global replace like:
s/RemoveAutofillProfilesAndCreditCardsModifiedBetween/RemoveAutofillDataModifiedBetween/
?

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
File chrome/browser/webdata/autofill_web_data_service_impl.h (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.h:1: 
Remove empty line.

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.h:52: virtual void
RemoveFormElementsAddedBetween(
ditto: grouping up top.

[kaiwang, 2013-03-25 23:06:48]

just went by

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/web_da...
File chrome/browser/webdata/web_data_service.h (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/web_da...
chrome/browser/webdata/web_data_service.h:96: : public WebDataServiceBase {
one line?

[Cait (Slow), 2013-03-26 14:29:23]

https://codereview.chromium.org/12987023/diff/1/chrome/browser/api/webdata/au...
File chrome/browser/api/webdata/autofill_web_data.h (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/api/webdata/au...
chrome/browser/api/webdata/autofill_web_data.h:83: // Removes form elements
recorded for Autocomplete from the database.
On 2013/03/25 21:50:38, dhollowa wrote:
> Please move this up near top to group with the other Autocomplete methods.

Done.

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
File chrome/browser/webdata/autofill_web_data_service_impl.cc (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.cc:164:
&AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl,
On 2013/03/25 21:50:38, dhollowa wrote:
> Gosh, this is excessive.  How would you feel about a global replace like:
>
s/RemoveAutofillProfilesAndCreditCardsModifiedBetween/RemoveAutofillDataModifiedBetween/
> ?
Done. There is a method of the same name on the AutofillTable as well, should I
update it too?

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
File chrome/browser/webdata/autofill_web_data_service_impl.h (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.h:1: 
On 2013/03/25 21:50:38, dhollowa wrote:
> Remove empty line.

Done.

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.h:52: virtual void
RemoveFormElementsAddedBetween(
On 2013/03/25 21:50:38, dhollowa wrote:
> ditto: grouping up top.

Done.

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/web_da...
File chrome/browser/webdata/web_data_service.h (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/web_da...
chrome/browser/webdata/web_data_service.h:96: : public WebDataServiceBase {
On 2013/03/25 23:06:48, kaiwang wrote:
> one line?

Done.

[dhollowa, 2013-03-26 15:14:09]

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
File chrome/browser/webdata/autofill_web_data_service_impl.cc (right):

https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
chrome/browser/webdata/autofill_web_data_service_impl.cc:164:
&AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl,
On 2013/03/26 14:29:23, caitkp wrote:
> On 2013/03/25 21:50:38, dhollowa wrote:
> > Gosh, this is excessive.  How would you feel about a global replace like:
> >
>
s/RemoveAutofillProfilesAndCreditCardsModifiedBetween/RemoveAutofillDataModifiedBetween/
> > ?
> Done. There is a method of the same name on the AutofillTable as well, should
I
> update it too?

Yes, please.

[dhollowa, 2013-03-26 15:16:09]

On 2013/03/26 15:14:09, dhollowa wrote:
>
https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
> File chrome/browser/webdata/autofill_web_data_service_impl.cc (right):
> 
>
https://codereview.chromium.org/12987023/diff/1/chrome/browser/webdata/autofi...
> chrome/browser/webdata/autofill_web_data_service_impl.cc:164:
>
&AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl,
> On 2013/03/26 14:29:23, caitkp wrote:
> > On 2013/03/25 21:50:38, dhollowa wrote:
> > > Gosh, this is excessive.  How would you feel about a global replace like:
> > >
> >
>
s/RemoveAutofillProfilesAndCreditCardsModifiedBetween/RemoveAutofillDataModifiedBetween/
> > > ?
> > Done. There is a method of the same name on the AutofillTable as well,
should
> I
> > update it too?
> 
> Yes, please.

And LGTM once that's done.  Thanks.

[commit-bot: I haz the power, 2013-03-26 17:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/12987023/10002

[commit-bot: I haz the power, 2013-03-26 20:44:45]

Change committed as 190757