Issue 12987006: Decouple managed mode code from the policy code in ProfileImpl.

Issue 12987006: Decouple managed mode code from the policy code in ProfileImpl. (Closed)

Created:
7 years, 9 months ago by Joao da Silva

Modified:
7 years, 9 months ago

Reviewers:
Bernhard Bauer, Miranda Callahan

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Decouple managed mode code from the policy code in ProfileImpl. This makes it possible to have builds with policy enabled, but managed mode disabled. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190452

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	chrome/browser/profiles/profile_impl.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	chrome/browser/profiles/profile_impl.cc	View		4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

@bauerb: please review @mirandac: please do an OWNER check Thanks!

7 years, 9 months ago (2013-03-25 09:12:14 UTC) #1

Bernhard Bauer

lgtm https://codereview.chromium.org/12987006/diff/1/chrome/browser/profiles/profile_impl.h File chrome/browser/profiles/profile_impl.h (right): https://codereview.chromium.org/12987006/diff/1/chrome/browser/profiles/profile_impl.h#newcode211 chrome/browser/profiles/profile_impl.h:211: #endif Nit: Could you add comments to the ...

7 years, 9 months ago (2013-03-25 10:36:36 UTC) #2

Joao da Silva

https://codereview.chromium.org/12987006/diff/1/chrome/browser/profiles/profile_impl.h File chrome/browser/profiles/profile_impl.h (right): https://codereview.chromium.org/12987006/diff/1/chrome/browser/profiles/profile_impl.h#newcode211 chrome/browser/profiles/profile_impl.h:211: #endif On 2013/03/25 10:36:36, Bernhard Bauer wrote: > Nit: ...

7 years, 9 months ago (2013-03-25 10:42:11 UTC) #3

Miranda Callahan

On 2013/03/25 10:42:11, Joao da Silva wrote: > https://codereview.chromium.org/12987006/diff/1/chrome/browser/profiles/profile_impl.h > File chrome/browser/profiles/profile_impl.h (right): > > ...

7 years, 9 months ago (2013-03-25 15:07:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12987006/3002

7 years, 9 months ago (2013-03-25 15:47:07 UTC) #5

Message was sent while issue was closed.

Change committed as 190452

Expand Messages | Collapse Messages