Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 12987003: Android: move sandbox_linux_unittests to stable tests. (Closed)

Created:
7 years, 9 months ago by jln (very slow on Chromium)
Modified:
7 years, 9 months ago
Reviewers:
Yaron, Isaac (away), nilesh
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org
Visibility:
Public.

Description

Android: move sandbox/breakpad to stable tests. sandbox_linux_unittests are no longer flaky, move them to stable. Move breakpad_unittests as well. BUG=169416 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190795

Patch Set 1 #

Patch Set 2 : Mark breakpad tests as stable as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/gtest/gtest_config.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jln (very slow on Chromium)
Isaac, now that sandbox_linux_unittests are not flaky, I would like to move them out of ...
7 years, 9 months ago (2013-03-22 18:45:21 UTC) #1
Isaac (away)
Given that we have have to kick these off of stable list twice already, I'd ...
7 years, 9 months ago (2013-03-22 19:47:59 UTC) #2
Isaac (away)
+nilesh, yfriedman
7 years, 9 months ago (2013-03-22 19:48:41 UTC) #3
jln (very slow on Chromium)
On 2013/03/22 19:47:59, Isaac wrote: > Given that we have have to kick these off ...
7 years, 9 months ago (2013-03-22 19:59:19 UTC) #4
Isaac (away)
Flaky tests in our stable list carries a significant penalty in terms of failed trybots ...
7 years, 9 months ago (2013-03-22 20:16:32 UTC) #5
Isaac (away)
lgtm. Could you move breakpad unit tests at the same time? Also let's just sort ...
7 years, 9 months ago (2013-03-26 21:44:27 UTC) #6
jln (very slow on Chromium)
On 2013/03/26 21:44:27, Isaac wrote: > lgtm. Could you move breakpad unit tests at the ...
7 years, 9 months ago (2013-03-26 22:11:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/12987003/12001
7 years, 9 months ago (2013-03-26 23:34:42 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 23:39:36 UTC) #9
Message was sent while issue was closed.
Change committed as 190795

Powered by Google App Engine
This is Rietveld 408576698