Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: chrome/browser/chrome_browser_field_trials.h

Issue 12985002: Add a new App launcher promo to the apps page / NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OWNERS review round 4. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_browser_field_trials.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_field_trials.h
diff --git a/chrome/browser/chrome_browser_field_trials.h b/chrome/browser/chrome_browser_field_trials.h
index dc92241cdcee687d4496fe43661a74bbc334abf6..bd0cf6274a365b29c9e48a9a0e30b67779269b59 100644
--- a/chrome/browser/chrome_browser_field_trials.h
+++ b/chrome/browser/chrome_browser_field_trials.h
@@ -10,16 +10,16 @@
#include "base/gtest_prod_util.h"
#include "base/time.h"
+class PrefService;
+
class ChromeBrowserFieldTrials {
public:
explicit ChromeBrowserFieldTrials(const CommandLine& command_line);
~ChromeBrowserFieldTrials();
// Called by the browser main sequence to set up Field Trials for this client.
- // |install_time| is the time this browser was installed (or the last time
- // prefs was reset). |install_time| is used by trials that are only created
- // for new installs of the browser.
- void SetupFieldTrials(const base::Time& install_time);
+ // |local_state| is used to extract properties like install time.
+ void SetupFieldTrials(PrefService* local_state);
private:
FRIEND_TEST_ALL_PREFIXES(BrowserMainTest,
@@ -30,7 +30,13 @@ class ChromeBrowserFieldTrials {
// Sets up common desktop-only field trials.
// Add an invocation of your field trial init function to this method, or to
// SetupFieldTrials if it is for all platforms.
- void SetupDesktopFieldTrials();
+ // |local_state| is needed by some other methods called from within this one.
+ void SetupDesktopFieldTrials(PrefService* local_state);
+
+ // This is not quite a field trial initialization, but it's an initialization
+ // that depends on a field trial, so why not? :-)
+ // |local_state| is needed to reset a local pref based on the chosen group.
+ void SetupAppLauncherFieldTrial(PrefService* local_state);
// A/B test for spdy when --use-spdy not set.
void SpdyFieldTrial();
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_browser_field_trials.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698