Fixed the speech crash when the render view has gone away then users click "try again"

Fixed the speech crash when the render view has gone away then users click "try again".

After a speech recognition session is done, chrome will pop up a bubble to allow users to choose "cancel" or "try again".
If the users choose "try again", it will use the last session's SpeechRecognitionSessionConfig which is stored in ChromeSpeechRecognitionManagerDelegate to create a new session.
But the render view might have gone away if the page is automatically refreshed to another url. Then the event_listener in the SpeechRecognitionSessionConfig is not valid anymore and should not be used.

This patch added a OnAbortSessionsForListener callback from SpeechRecognitionManagerImpl to ChromeSpeechRecognitionManagerDelegate to notify chrome we should not try to restore the session for "try again" event.

BUG=222000
TEST=open the PoC.html in the issue, click on the page and then click on "try again" button.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192299

[no longer working on chromium, 2013-03-27 15:08:13]

Tommi, please take a look.

[tommi (sloooow) - chröme, 2013-03-28 10:38:46]

https://codereview.chromium.org/12982009/diff/1/chrome/browser/speech/chrome_...
File chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
(right):

https://codereview.chromium.org/12982009/diff/1/chrome/browser/speech/chrome_...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:278: void
ChromeSpeechRecognitionManagerDelegate::RestartLastSession() {
Hmm... rename to MaybeRestartLastSession?

https://codereview.chromium.org/12982009/diff/1/chrome/browser/speech/chrome_...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:280: return;
what effect does this have on the functionality?
Also, please add a comment for how we can get here.

https://codereview.chromium.org/12982009/diff/1/chrome/browser/speech/chrome_...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:316:
last_session_config_.reset(new content::SpeechRecognitionSessionConfig(
I'm looking for this constructor in the code but I can't find it! :)
I only see a default constructor for this type:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

Was it added very recently or has it been removed?

https://codereview.chromium.org/12982009/diff/1/chrome/browser/speech/chrome_...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:478:
SpeechRecognitionEventListener* listener) {
Passing the listener here feels hacky.  I would rather want to have something
like:
OnSessionAborted(int session_id)

Or if there's at most ever only one session active, then no parameter.
In what cases can this function be called and the listener does not match
last_session_config_->event_listener?

https://codereview.chromium.org/12982009/diff/1/content/browser/speech/speech...
File content/browser/speech/speech_recognition_manager_impl.cc (right):

https://codereview.chromium.org/12982009/diff/1/content/browser/speech/speech...
content/browser/speech/speech_recognition_manager_impl.cc:434:
delegate_->OnAbortSessionsForListener(listener);
I think we can improve upon the name of the method.  It's always just one
session, not many, right?  What about OnSessionAborted?

[no longer working on chromium, 2013-04-03 09:34:04]

Tommi, I stepped back and looked deeper at the code, and figured out the the
correct solution should be using the TabWatcher to shut down the bubble when the
tab is going away.

Please take another look.

SX

[tommi (sloooow) - chröme, 2013-04-03 09:38:30]

https://codereview.chromium.org/12982009/diff/9001/chrome/browser/speech/chro...
File chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
(right):

https://codereview.chromium.org/12982009/diff/9001/chrome/browser/speech/chro...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:228: typedef
std::map< content::WebContents*, std::pair<int, int> > WebContentsMap;
no space after <

https://codereview.chromium.org/12982009/diff/9001/chrome/browser/speech/chro...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:228: typedef
std::map< content::WebContents*, std::pair<int, int> > WebContentsMap;
instead of std::pair, let's define a struct with proper names for these
variables.

[no longer working on chromium, 2013-04-03 11:19:55]

https://codereview.chromium.org/12982009/diff/9001/chrome/browser/speech/chro...
File chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
(right):

https://codereview.chromium.org/12982009/diff/9001/chrome/browser/speech/chro...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:228: typedef
std::map< content::WebContents*, std::pair<int, int> > WebContentsMap;
On 2013/04/03 09:38:30, tommi wrote:
> instead of std::pair, let's define a struct with proper names for these
> variables.

Done with changing the code to use vector with struct.

[no longer working on chromium, 2013-04-04 08:17:21]

ping

[tommi (sloooow) - chröme, 2013-04-04 09:11:50]

lgtm

[commit-bot: I haz the power, 2013-04-04 09:19:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/12982009/14001

[commit-bot: I haz the power, 2013-04-04 11:37:12]

Change committed as 192299