[chromedriver] Fix 3 bugs about web view, window handle and target window.

[chromedriver] Fix 3 bugs about web view, window handle and target window.

Main change is the interface of chrome.h

BUG=chromedriver:241, chromedriver:248, chromedriver:254
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190537

[chrisgao (Use stgao instead), 2013-03-22 23:29:46]

ptal

https://codereview.chromium.org/12978003/diff/1/chrome/test/chromedriver/chro...
File chrome/test/chromedriver/chrome/chrome_impl.h (right):

https://codereview.chromium.org/12978003/diff/1/chrome/test/chromedriver/chro...
chrome/test/chromedriver/chrome/chrome_impl.h:62: // Ids in this list are in the
same order as the window opened.
window->web view

[chrisgao (Use stgao instead), 2013-03-25 18:15:44]

Hi Craig,

Would you please take a look at my new patch?

Best wishes,
Shuotao Gao

[craigdh1, 2013-03-25 18:43:17]

Yep, it's on my plate as soon as I get a moment. I've got a couple high
priority things right now but I'll try to get to it before the end of the
day.

-Craig


On Mon, Mar 25, 2013 at 11:15 AM, <chrisgao@chromium.org> wrote:

> Hi Craig,
>
> Would you please take a look at my new patch?
>
> Best wishes,
> Shuotao Gao
>
>
https://codereview.chromium.**org/12978003/<https://codereview.chromium.org/1...
>

[craigdh, 2013-03-25 22:21:40]

lgtm with nit.

https://codereview.chromium.org/12978003/diff/12001/chrome/test/chromedriver/...
File chrome/test/chromedriver/chrome/chrome_impl.cc (right):

https://codereview.chromium.org/12978003/diff/12001/chrome/test/chromedriver/...
chrome/test/chromedriver/chrome/chrome_impl.cc:269: for (WebViewList::iterator
it= web_views_.begin();
space between it and =

[chrisgao (Use stgao instead), 2013-03-25 23:02:19]

Thanks Craig!

https://codereview.chromium.org/12978003/diff/12001/chrome/test/chromedriver/...
File chrome/test/chromedriver/chrome/chrome_impl.cc (right):

https://codereview.chromium.org/12978003/diff/12001/chrome/test/chromedriver/...
chrome/test/chromedriver/chrome/chrome_impl.cc:269: for (WebViewList::iterator
it= web_views_.begin();
On 2013/03/25 22:21:40, craigdh wrote:
> space between it and =

Done.

[commit-bot: I haz the power, 2013-03-26 00:54:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/12978003/23001

[commit-bot: I haz the power, 2013-03-26 01:01:29]

Change committed as 190537