Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1297503008: Remove stale includes, mark histogram as obsolete. (Closed)

Created:
5 years, 4 months ago by wjmaclean
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang, gab, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale includes, mark histogram as obsolete. This CL removes some stale includes missed by https://codereview.chromium.org/1295323002/ and marks the histogram Settings.ZoomLevelPreferencesMigrated as 'obsolete'. TBR=thestig@chromium.org BUG=420643 Committed: https://crrev.com/15b71416d97d588865d27daefa5f97541c45cf2f Cr-Commit-Position: refs/heads/master@{#344775}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify obsolescence comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (11 generated)
wjmaclean
Addressing issues from comments on https://codereview.chromium.org/1295323002/, please take a look.
5 years, 4 months ago (2015-08-19 13:52:56 UTC) #2
gab
lgtm, thanks https://codereview.chromium.org/1297503008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1297503008/diff/1/tools/metrics/histograms/histograms.xml#newcode40104 tools/metrics/histograms/histograms.xml:40104: + of users have had their zoom ...
5 years, 4 months ago (2015-08-19 19:35:08 UTC) #3
wjmaclean
mpearson@chromium.org: Please review changes in histograms.xml
5 years, 4 months ago (2015-08-19 19:53:36 UTC) #5
wjmaclean
rkaplow@chromium.org: Please review changes in histograms.xml
5 years, 4 months ago (2015-08-19 19:54:49 UTC) #8
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-19 21:06:04 UTC) #10
wjmaclean
jwd@chromium.org: Please review changes in histograms.xml
5 years, 4 months ago (2015-08-20 12:15:01 UTC) #13
jwd
lgtm
5 years, 4 months ago (2015-08-20 18:46:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297503008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297503008/20001
5 years, 4 months ago (2015-08-20 18:53:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58452)
5 years, 4 months ago (2015-08-20 21:56:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297503008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297503008/20001
5 years, 4 months ago (2015-08-21 13:22:00 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 15:42:00 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 15:42:39 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15b71416d97d588865d27daefa5f97541c45cf2f
Cr-Commit-Position: refs/heads/master@{#344775}

Powered by Google App Engine
This is Rietveld 408576698