Issue 12972006: Display user account name in password and passphrase activity prompt.

Issue 12972006: Display user account name in password and passphrase activity prompt. (Closed)

Created:
7 years, 9 months ago by acleung1

Modified:
7 years, 9 months ago

Reviewers:
nyquist, nilesh, tim (not reviewing), ainslie

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Display user account name in password and passphrase activity prompt. BUG=196350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190633

Patch Set 2 : Move it out of hint. #

Total comments: 2

Patch Set 3 : Fix indent. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_android.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_android.cc	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

acleung1

Hi Tommy This adds the hint strings to ProfileSyncService. I haven't been able to get ...

7 years, 9 months ago (2013-03-21 00:27:38 UTC) #1

acleung1

On 2013/03/21 00:27:38, acleung1 wrote: > Hi Tommy > > This adds the hint strings ...

7 years, 9 months ago (2013-03-23 00:30:43 UTC) #2

acleung1

On 2013/03/25 22:08:51, nyquist wrote: > lgtm Adding Tim and Nilesh for OWNER approval.

7 years, 9 months ago (2013-03-25 22:11:27 UTC) #4

nilesh

Please fix issue title and description. s/promot/prompt LGTM

7 years, 9 months ago (2013-03-25 22:52:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/12972006/3001

7 years, 9 months ago (2013-03-25 23:14:24 UTC) #6

commit-bot: I haz the power

Presubmit check for 12972006-3001 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...

7 years, 9 months ago (2013-03-25 23:14:27 UTC) #7

tim (not reviewing)

LGTM with nit https://codereview.chromium.org/12972006/diff/3001/chrome/browser/sync/profile_sync_service_android.cc File chrome/browser/sync/profile_sync_service_android.cc (right): https://codereview.chromium.org/12972006/diff/3001/chrome/browser/sync/profile_sync_service_android.cc#newcode394 chrome/browser/sync/profile_sync_service_android.cc:394: IDS_SYNC_ACCOUNT_SYNCING_TO_USER, indent off (two more spaces)

7 years, 9 months ago (2013-03-26 01:04:36 UTC) #8

acleung1

Thanks Tim and Nilesh https://codereview.chromium.org/12972006/diff/3001/chrome/browser/sync/profile_sync_service_android.cc File chrome/browser/sync/profile_sync_service_android.cc (right): https://codereview.chromium.org/12972006/diff/3001/chrome/browser/sync/profile_sync_service_android.cc#newcode394 chrome/browser/sync/profile_sync_service_android.cc:394: IDS_SYNC_ACCOUNT_SYNCING_TO_USER, On 2013/03/26 01:04:36, timsteele ...

7 years, 9 months ago (2013-03-26 01:48:48 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/12972006/8002

7 years, 9 months ago (2013-03-26 01:49:53 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/12972006/8002

7 years, 9 months ago (2013-03-26 07:09:59 UTC) #11

Message was sent while issue was closed.

Change committed as 190633

Expand Messages | Collapse Messages