Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12968004: Implemented new UI for error messages on OOBE/Login. (Closed)

Created:
7 years, 9 months ago by dzhioev (left Google)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implemented new UI for error messages on OOBE/Login. UI changed for network errors screen and for TPM error screen. In addition fixed vertical positioning of all OOBE/Login screens. BUG=179676 TBR=nkostylev Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190650

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -142 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 5 chunks +18 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/login/display_manager.js View 1 chunk +0 lines, -4 lines 2 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 6 chunks +10 lines, -12 lines 1 comment Download
M chrome/browser/resources/chromeos/login/screen_error_message.css View 2 chunks +48 lines, -32 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.html View 1 chunk +31 lines, -22 lines 1 comment Download
M chrome/browser/resources/chromeos/login/screen_error_message.js View 8 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_tpm_error.css View 1 chunk +5 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_tpm_error.html View 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_tpm_error.js View 1 chunk +16 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 4 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dzhioev (left Google)
7 years, 9 months ago (2013-03-25 22:11:53 UTC) #1
ygorshenin1
lgtm https://codereview.chromium.org/12968004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/12968004/diff/1/chrome/app/chromeos_strings.grdp#newcode3578 chrome/app/chromeos_strings.grdp:3578: <message name="IDS_LOGIN_PROXY_ERROR_TITLE" desc="A tittle of screen containg an ...
7 years, 9 months ago (2013-03-26 07:11:35 UTC) #2
dzhioev (left Google)
https://codereview.chromium.org/12968004/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/12968004/diff/1/chrome/app/chromeos_strings.grdp#newcode3578 chrome/app/chromeos_strings.grdp:3578: <message name="IDS_LOGIN_PROXY_ERROR_TITLE" desc="A tittle of screen containg an message ...
7 years, 9 months ago (2013-03-26 07:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/12968004/6001
7 years, 9 months ago (2013-03-26 08:19:19 UTC) #4
commit-bot: I haz the power
Presubmit check for 12968004-6001 failed and returned exit status 1. INFO:root:Found 14 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-26 08:19:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/12968004/6001
7 years, 9 months ago (2013-03-26 08:23:02 UTC) #6
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/12968004/diff/6001/chrome/browser/resources/chromeos/login/display_manager.js File chrome/browser/resources/chromeos/login/display_manager.js (left): https://chromiumcodereview.appspot.com/12968004/diff/6001/chrome/browser/resources/chromeos/login/display_manager.js#oldcode444 chrome/browser/resources/chromeos/login/display_manager.js:444: login.ErrorMessageScreen.updateLocalizedContent(); How is this handled now? https://chromiumcodereview.appspot.com/12968004/diff/6001/chrome/browser/resources/chromeos/login/oobe.css File ...
7 years, 9 months ago (2013-03-26 08:31:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=127528
7 years, 9 months ago (2013-03-26 09:33:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/12968004/6001
7 years, 9 months ago (2013-03-26 09:44:06 UTC) #9
dzhioev (left Google)
https://chromiumcodereview.appspot.com/12968004/diff/6001/chrome/browser/resources/chromeos/login/display_manager.js File chrome/browser/resources/chromeos/login/display_manager.js (left): https://chromiumcodereview.appspot.com/12968004/diff/6001/chrome/browser/resources/chromeos/login/display_manager.js#oldcode444 chrome/browser/resources/chromeos/login/display_manager.js:444: login.ErrorMessageScreen.updateLocalizedContent(); On 2013/03/26 08:31:15, Nikita Kostylev wrote: > How ...
7 years, 9 months ago (2013-03-26 09:48:06 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 12:47:04 UTC) #11
Message was sent while issue was closed. 
Change committed as 190650

Powered by Google App Engine
This is Rietveld 408576698