cc/resources/picture_layer_tiling_unittest.cc - Issue 12967018: cc: Avoid pointless gfx::Point/Size contructors when making Rects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/picture_layer_tiling_unittest.cc

Issue 12967018: cc: Avoid pointless gfx::Point/Size contructors when making Rects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: RectFs as well Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/resources/picture_layer_tiling_unittest.cc

diff --git a/cc/resources/picture_layer_tiling_unittest.cc b/cc/resources/picture_layer_tiling_unittest.cc

index 5af03ad28f26988a93c4b8b80b7e39dd9a0bff6c..fd699266082a99b0cef27b4ad8b9c4300c22cdaa 100644

--- a/cc/resources/picture_layer_tiling_unittest.cc

+++ b/cc/resources/picture_layer_tiling_unittest.cc

@@ -157,9 +157,9 @@ TEST_F(PictureLayerTilingIteratorTest, NonIntersectingRect) {

TEST_F(PictureLayerTilingIteratorTest, LayerEdgeTextureCoordinates) {

Initialize(gfx::Size(300, 300), 1.0f, gfx::Size(256, 256));

// All of these sizes are 256x256, scaled and ceiled.

- VerifyTilesExactlyCoverRect(1.0f, gfx::Rect(gfx::Size(256, 256)));

- VerifyTilesExactlyCoverRect(0.8f, gfx::Rect(gfx::Size(205, 205)));

- VerifyTilesExactlyCoverRect(1.2f, gfx::Rect(gfx::Size(308, 308)));

+ VerifyTilesExactlyCoverRect(1.0f, gfx::Rect(0, 0, 256, 256));

+ VerifyTilesExactlyCoverRect(0.8f, gfx::Rect(0, 0, 205, 205));

+ VerifyTilesExactlyCoverRect(1.2f, gfx::Rect(0, 0, 308, 308));

}

TEST_F(PictureLayerTilingIteratorTest, NonContainedDestRect) {