Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 12967018: cc: Avoid pointless gfx::Point/Size contructors when making Rects. (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Avoid pointless gfx::Point/Size contructors when making Rects. Instead of gfx::Rect(gfx::Point(), gfx::Size(3, 4)), use gfx::Rect(0, 0, 3, 4). Instead of gfx::Rect(gfx::Point(), some_size), use gfx::Rect(some_size). R=jamesr NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190547

Patch Set 1 #

Patch Set 2 : RectFs as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -133 lines) Patch
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/solid_color_layer_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/tiled_layer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/tiled_layer_impl_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 9 chunks +14 lines, -15 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/layer_tiling_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/scheduler/texture_uploader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 24 chunks +49 lines, -58 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
7 years, 9 months ago (2013-03-25 20:57:51 UTC) #1
jamesr
lgtm
7 years, 9 months ago (2013-03-25 21:01:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12967018/4001
7 years, 9 months ago (2013-03-25 21:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12967018/4001
7 years, 9 months ago (2013-03-26 03:08:06 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 03:14:12 UTC) #5
Message was sent while issue was closed.
Change committed as 190547

Powered by Google App Engine
This is Rietveld 408576698