Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Issue 12967017: [chromedriver] Disable failed java tests in bots. (Closed)

Created:
7 years, 9 months ago by chrisgao (Use stgao instead)
Modified:
7 years, 9 months ago
Reviewers:
kkania
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Disable failed java tests in bots. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190480

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Patch Set 3 : Fix 80 characters error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M chrome/test/chromedriver/run_java_tests.py View 1 2 2 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
chrisgao (Use stgao instead)
ptal
7 years, 9 months ago (2013-03-25 20:38:38 UTC) #1
kkania
lgtm https://codereview.chromium.org/12967017/diff/1/chrome/test/chromedriver/run_java_tests.py File chrome/test/chromedriver/run_java_tests.py (right): https://codereview.chromium.org/12967017/diff/1/chrome/test/chromedriver/run_java_tests.py#newcode29 chrome/test/chromedriver/run_java_tests.py:29: _DESKTOP_OS_SPECIFIC_FILTER = [] the other two are called ...
7 years, 9 months ago (2013-03-25 20:45:10 UTC) #2
chrisgao (Use stgao instead)
https://codereview.chromium.org/12967017/diff/1/chrome/test/chromedriver/run_java_tests.py File chrome/test/chromedriver/run_java_tests.py (right): https://codereview.chromium.org/12967017/diff/1/chrome/test/chromedriver/run_java_tests.py#newcode29 chrome/test/chromedriver/run_java_tests.py:29: _DESKTOP_OS_SPECIFIC_FILTER = [] On 2013/03/25 20:45:10, kkania wrote: > ...
7 years, 9 months ago (2013-03-25 20:50:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/12967017/5001
7 years, 9 months ago (2013-03-25 20:51:37 UTC) #4
commit-bot: I haz the power
Presubmit check for 12967017-5001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-25 20:51:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/12967017/9001
7 years, 9 months ago (2013-03-25 21:02:17 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 21:09:54 UTC) #7
Message was sent while issue was closed.
Change committed as 190480

Powered by Google App Engine
This is Rietveld 408576698