chrome/browser/extensions/api/management/management_browsertest.cc - Issue 12967016: Improve <adview> implementation and add tests.

Unified Diff: chrome/browser/extensions/api/management/management_browsertest.cc

Issue 12967016: Improve <adview> implementation and add tests. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Fix comment. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/ad_view_browsertest.cc ('K') | « chrome/browser/extensions/ad_view_browsertest.cc ('k') | chrome/browser/extensions/extension_disabled_ui_browsertest.cc » ('j') | content/test/net/url_request_prepackaged_interceptor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc

index b2dc0498ae94b5f3e1ad34170b6ecd2ee3308bc2..03b0514ad00ed3bb219436846485f472e1027859 100644

--- a/chrome/browser/extensions/api/management/management_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_browsertest.cc

@@ -250,7 +250,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_AutoUpdate) {

NotificationListener notification_listener;

base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");

// Note: This interceptor gets requests on the IO thread.

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

net::URLFetcher::SetEnableInterceptionForTests(true);

interceptor.SetResponseIgnoreQuery(

@@ -336,7 +336,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,

NotificationListener notification_listener;

base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");

// Note: This interceptor gets requests on the IO thread.

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

net::URLFetcher::SetEnableInterceptionForTests(true);

interceptor.SetResponseIgnoreQuery(

@@ -412,7 +412,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_ExternalUrlUpdate) {

base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");

// Note: This interceptor gets requests on the IO thread.

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

net::URLFetcher::SetEnableInterceptionForTests(true);

interceptor.SetResponseIgnoreQuery(

@@ -498,7 +498,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalPolicyRefresh) {

base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");

// Note: This interceptor gets requests on the IO thread.

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

net::URLFetcher::SetEnableInterceptionForTests(true);

interceptor.SetResponseIgnoreQuery(

@@ -573,7 +573,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,

ASSERT_TRUE(service->disabled_extensions()->is_empty());

// Note: This interceptor gets requests on the IO thread.

- content::URLRequestPrepackagedInterceptor interceptor;

+ content::URLLocalHostRequestPrepackagedInterceptor interceptor;

net::URLFetcher::SetEnableInterceptionForTests(true);

interceptor.SetResponseIgnoreQuery(