chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/chrometest.js - Issue 12967016: Improve <adview> implementation and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/chrometest.js

Issue 12967016: Improve <adview> implementation and add tests. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Code review feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/ad_view_browsertest.cc ('K') | « chrome/test/data/extensions/platform_apps/ad_view/loadcommit_event/manifest.json ('k') | chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/displayad.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/chrometest.js

diff --git a/chrome/test/data/extensions/platform_apps/ad_view/ad_network_loaded/chrometest.js b/chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/chrometest.js

similarity index 82%

rename from chrome/test/data/extensions/platform_apps/ad_view/ad_network_loaded/chrometest.js

rename to chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/chrometest.js

index f4f4f596ca8ce6c35ee7a6b047221e267cfce6e7..65352ad9e19b33dd05469dc9b16c89a8615bdd0e 100644

--- a/chrome/test/data/extensions/platform_apps/ad_view/ad_network_loaded/chrometest.js

+++ b/chrome/test/data/extensions/platform_apps/ad_view/onloadcommit_ack/chrometest.js

@@ -4,7 +4,7 @@

chrome.test.getConfig(function(config) {

var guestURL = 'http://localhost:' + config.testServer.port +

- '/files/extensions/platform_apps/ad_view/ad_network/testsdk.html';

+ '/files/extensions/platform_apps/ad_view/ad_network_site/testsdk.html';

var adview = document.getElementsByTagName("adview")[0];

@@ -19,7 +19,7 @@ chrome.test.getConfig(function(config) {

window.addEventListener("message", function(event) {

if (event.data.message == "onloadcommit-ack") {

- chrome.test.sendMessage("ad-network-loaded");

+ chrome.test.sendMessage("onloadcommit-ack-message");

}

})

});