chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/chrometest.js - Issue 12967016: Improve <adview> implementation and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/chrometest.js

Issue 12967016: Improve <adview> implementation and add tests. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Code review feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/ad_view_browsertest.cc ('K') | « chrome/test/data/extensions/platform_apps/ad_view/load_event/manifest.json ('k') | chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/index.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/chrometest.js

diff --git a/chrome/test/data/extensions/platform_apps/ad_view/load_event/chrometest.js b/chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/chrometest.js

similarity index 50%

copy from chrome/test/data/extensions/platform_apps/ad_view/load_event/chrometest.js

copy to chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/chrometest.js

index 0886f555365b8803186a065541f9686db003f350..054a293d46bbc4d0d6cfcb7b35b9385fabc70110 100644

--- a/chrome/test/data/extensions/platform_apps/ad_view/load_event/chrometest.js

+++ b/chrome/test/data/extensions/platform_apps/ad_view/loadabort_event/chrometest.js

@@ -3,12 +3,15 @@

// found in the LICENSE file.

chrome.test.getConfig(function(config) {

- var guestURL = 'http://localhost:' + config.testServer.port +

- '/files/extensions/platform_apps/ad_view/ad_network/testsdk.html';

+ var guestURL = 'http://255.255.255.255/fake_file.html';

var adview = document.getElementsByTagName("adview")[0];

- adview.addEventListener("loadcommit", function() {

- chrome.test.sendMessage('guest-loaded');

+ adview.addEventListener("loadabort", function(event) {

+ var url = event.url;

+ var isTopLevel = event.isTopLevel;

+ chrome.test.assertEq(guestURL, url);

+ chrome.test.assertEq(true, isTopLevel);

+ chrome.test.sendMessage('loadabort-received');

})

adview.setAttribute("src", guestURL);