chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html - Issue 12967016: Improve <adview> implementation and add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html

Issue 12967016: Improve <adview> implementation and add tests. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Code review feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/ad_view_browsertest.cc ('K') | « chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/chrometest.js ('k') | chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html

diff --git a/chrome/test/data/extensions/platform_apps/ad_view/display_first_ad/index.html b/chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html

similarity index 79%

copy from chrome/test/data/extensions/platform_apps/ad_view/display_first_ad/index.html

copy to chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html

index 79f45a2bc9d6369397a25bfd672221a691e840e8..07657e0c3266bf91e709060bb2e014554b094595 100644

--- a/chrome/test/data/extensions/platform_apps/ad_view/display_first_ad/index.html

+++ b/chrome/test/data/extensions/platform_apps/ad_view/invalid_ad_network/index.html

@@ -8,9 +8,9 @@

<head>

<title><adview> Sample</title>

- <script src="chrometest.js"></script>

</head>

<body>

- <adview id="my-adview" class="adview-element" ad-network="test"></adview>

-</<body>

+ <adview id="adview1" ad-network="invalidAdNetwork1"></adview>

+ <script src="chrometest.js"></script>

+</body>

</html>